Skip to content

Commit

Permalink
OCPBUGS-26498: Add UnservableInFutureVersions route status condition …
Browse files Browse the repository at this point in the history
…type

Add UnservableInFutureVersions as a route status condition type. This
change allows the router to indicate that a route is using an
unsupported configuration and will be unservable in the future. The
ingress operator may use this condition to block upgrades.
  • Loading branch information
gcs278 committed Feb 2, 2024
1 parent 12a8eb6 commit 34ed4ee
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion openapi/generated_openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -32842,7 +32842,7 @@
"default": ""
},
"type": {
"description": "Type is the type of the condition. Currently only Admitted.",
"description": "Type is the type of the condition. Currently only Admitted or UnservableInFutureVersions.",
"type": "string",
"default": ""
}
Expand Down
2 changes: 1 addition & 1 deletion route/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion route/v1/route-CustomNoUpgrade.crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ spec:
description: Status is the status of the condition. Can be True, False, Unknown.
type: string
type:
description: Type is the type of the condition. Currently only Admitted.
description: Type is the type of the condition. Currently only Admitted or UnservableInFutureVersions.
type: string
host:
description: Host is the host string under which the route is exposed; this value is required
Expand Down
2 changes: 1 addition & 1 deletion route/v1/route-TechPreviewNoUpgrade.crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ spec:
description: Status is the status of the condition. Can be True, False, Unknown.
type: string
type:
description: Type is the type of the condition. Currently only Admitted.
description: Type is the type of the condition. Currently only Admitted or UnservableInFutureVersions.
type: string
host:
description: Host is the host string under which the route is exposed; this value is required
Expand Down
2 changes: 1 addition & 1 deletion route/v1/route.crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ spec:
description: Status is the status of the condition. Can be True, False, Unknown.
type: string
type:
description: Type is the type of the condition. Currently only Admitted.
description: Type is the type of the condition. Currently only Admitted or UnservableInFutureVersions.
type: string
required:
- status
Expand Down
6 changes: 4 additions & 2 deletions route/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,16 @@ type RouteIngressConditionType string
const (
// RouteAdmitted means the route is able to service requests for the provided Host
RouteAdmitted RouteIngressConditionType = "Admitted"
// TODO: add other route condition types
// RouteUnservableInFutureVersions indicates that the route is using an unsupported
// configuration that may be incompatible with a future version of OpenShift.
RouteUnservableInFutureVersions RouteIngressConditionType = "UnservableInFutureVersions"
)

// RouteIngressCondition contains details for the current condition of this route on a particular
// router.
type RouteIngressCondition struct {
// Type is the type of the condition.
// Currently only Admitted.
// Currently only Admitted or UnservableInFutureVersions.
Type RouteIngressConditionType `json:"type" protobuf:"bytes,1,opt,name=type,casttype=RouteIngressConditionType"`
// Status is the status of the condition.
// Can be True, False, Unknown.
Expand Down
2 changes: 1 addition & 1 deletion route/v1/zz_generated.swagger_doc_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 34ed4ee

Please sign in to comment.