Skip to content

Commit

Permalink
Change PreviousFlakePercentage value type from int to float
Browse files Browse the repository at this point in the history
PreviousFlakePercentage field in SippyTestInfo struct should be
float instead of int given percentage value can be decimal. The data
from Sippy does return previous_flake_percentage as decimal.

Signed-off-by: Vu Dinh <vudinh@outlook.com>
  • Loading branch information
dinhxuanvu committed Apr 18, 2024
1 parent d7cb422 commit 3f13d95
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/codegen/pkg/sippy/json_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type SippyTestInfo struct {
PreviousFlakes int `json:"previous_flakes"`
PreviousPassPercentage float64 `json:"previous_pass_percentage"`
PreviousFailurePercentage float64 `json:"previous_failure_percentage"`
PreviousFlakePercentage int `json:"previous_flake_percentage"`
PreviousFlakePercentage float64 `json:"previous_flake_percentage"`
PreviousWorkingPercentage float64 `json:"previous_working_percentage"`
PreviousRuns int `json:"previous_runs"`
NetFailureImprovement float64 `json:"net_failure_improvement"`
Expand Down

0 comments on commit 3f13d95

Please sign in to comment.