Skip to content

Commit

Permalink
MON-3486: add feature gate for Collection Profiles
Browse files Browse the repository at this point in the history
Adds a custom feature gate for CMO's Collection Profiles feature. Also
preserve the earlier behavior to enable it by default on TP enabled
clusters.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
  • Loading branch information
rexagod committed Mar 27, 2024
1 parent 4b072d8 commit 824dc01
Show file tree
Hide file tree
Showing 7 changed files with 403 additions and 0 deletions.
7 changes: 7 additions & 0 deletions config/v1/feature_gates.go
Original file line number Diff line number Diff line change
Expand Up @@ -559,4 +559,11 @@ var (
productScope(ocpSpecific).
enableIn(TechPreviewNoUpgrade).
mustRegister()

FeatureGateMetricsCollectionProfiles = newFeatureGate("MetricsCollectionProfiles").
reportProblemsToJiraComponent("Monitoring").
contactPerson("rexagod").
productScope(ocpSpecific).
enableIn(Default, TechPreviewNoUpgrade).
mustRegister()
)
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@
{
"name": "KMSv1"
},
{
"name": "MetricsCollectionProfiles"
},
{
"name": "NetworkLiveMigration"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@
{
"name": "MaxUnavailableStatefulSet"
},
{
"name": "MetricsCollectionProfiles"
},
{
"name": "MetricsServer"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@
{
"name": "KMSv1"
},
{
"name": "MetricsCollectionProfiles"
},
{
"name": "NetworkLiveMigration"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@
{
"name": "MaxUnavailableStatefulSet"
},
{
"name": "MetricsCollectionProfiles"
},
{
"name": "MetricsServer"
},
Expand Down
191 changes: 191 additions & 0 deletions payload-manifests/featuregates/featureGate-SingleNode-Default.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
{
"apiVersion": "config.openshift.io/v1",
"kind": "FeatureGate",
"metadata": {
"annotations": {
"include.release.openshift.io/single-node-developer": "false-except-for-the-config-operator"
},
"creationTimestamp": null,
"name": "cluster"
},
"spec": {},
"status": {
"featureGates": [
{
"disabled": [
{
"name": "AdminNetworkPolicy"
},
{
"name": "AlertingRules"
},
{
"name": "AutomatedEtcdBackup"
},
{
"name": "CSIDriverSharedResource"
},
{
"name": "ClusterAPIInstall"
},
{
"name": "DNSNameResolver"
},
{
"name": "DisableKubeletCloudCredentialProviders"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EventedPLEG"
},
{
"name": "Example"
},
{
"name": "ExternalOIDC"
},
{
"name": "ExternalRouteCertificate"
},
{
"name": "GCPClusterHostedDNS"
},
{
"name": "GCPLabelsTags"
},
{
"name": "GatewayAPI"
},
{
"name": "HardwareSpeed"
},
{
"name": "ImagePolicy"
},
{
"name": "InsightsConfig"
},
{
"name": "InsightsConfigAPI"
},
{
"name": "InsightsOnDemandDataGather"
},
{
"name": "InstallAlternateInfrastructureAWS"
},
{
"name": "MachineAPIOperatorDisableMachineHealthCheckController"
},
{
"name": "MachineAPIProviderOpenStack"
},
{
"name": "MachineConfigNodes"
},
{
"name": "ManagedBootImages"
},
{
"name": "MaxUnavailableStatefulSet"
},
{
"name": "MetricsServer"
},
{
"name": "MixedCPUsAllocation"
},
{
"name": "NewOLM"
},
{
"name": "NodeSwap"
},
{
"name": "OnClusterBuild"
},
{
"name": "PinnedImages"
},
{
"name": "PlatformOperators"
},
{
"name": "RouteExternalCertificate"
},
{
"name": "SignatureStores"
},
{
"name": "SigstoreImageVerification"
},
{
"name": "TranslateStreamCloseWebsocketRequests"
},
{
"name": "UpgradeStatus"
},
{
"name": "ValidatingAdmissionPolicy"
},
{
"name": "VolumeGroupSnapshot"
}
],
"enabled": [
{
"name": "AlibabaPlatform"
},
{
"name": "AzureWorkloadIdentity"
},
{
"name": "BareMetalLoadBalancer"
},
{
"name": "BuildCSIVolumes"
},
{
"name": "CloudDualStackNodeIPs"
},
{
"name": "ExternalCloudProvider"
},
{
"name": "ExternalCloudProviderAzure"
},
{
"name": "ExternalCloudProviderExternal"
},
{
"name": "ExternalCloudProviderGCP"
},
{
"name": "KMSv1"
},
{
"name": "MetricsCollectionProfiles"
},
{
"name": "NetworkLiveMigration"
},
{
"name": "OpenShiftPodSecurityAdmission"
},
{
"name": "PrivateHostedZoneAWS"
},
{
"name": "VSphereControlPlaneMachineSet"
},
{
"name": "VSphereStaticIPs"
}
],
"version": ""
}
]
}
}

0 comments on commit 824dc01

Please sign in to comment.