Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "config/v1/types_oauth: add OAuthAudit" #1073

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Nov 29, 2021

What

This reverts commit afee15a. Which reflects the API change necessary for the AUTH-6 epic of Audit Logging on Authentication events.

Why

The feature won't make it into 4.10 and needs to be reverted as an API that does nothing is broken.

The commit will be re-applied for 4.11.

This reverts commit afee15a. Which
reflects the API change necessary for the AUTH-6 epic of Audit Logging
on Authentication events. The feature won't make it into 4.10 and needs
to be reverted as an API that does nothing is broken.

The commit will be re-applied for 4.11.

Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
Copy link
Contributor Author

ibihim commented Nov 29, 2021

@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, s-urbaniak, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit e34bc22 into openshift:master Nov 30, 2021
@ibihim ibihim deleted the AUTH-110-revert_audit_profile_change branch November 30, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants