helm: add a new namespaced CRD for helm

[zonggen]

As part of the process to support namespace-scoped Helm repositories for
non-admin users, this PR adds a new namespace-scoped CRD definition
named projecthelmchartrepositories.helm.openshift.io.

Enhancement (under review): openshift/enhancements#949
Closes: https://issues.redhat.com/browse/HELM-258
Signed-off-by: Allen Bai abai@redhat.com

[zonggen]

/hold
Until the enhancement is approved and merged.

[zonggen]

Not sure if this is related, but make verify-scripts was passing locally for me. Ran with go mod tidy, go mod vendor, followed by make verify-scripts.

$ go version 
go version go1.17.5 linux/amd64

[dperaza4dustbit]

LGTM

[zonggen]

@pedjak Could you also take a look at this change? Tagging you because you were the author of last Helm CRD change.

[zonggen]

Since the enhancement is merged openshift/enhancements#949,

/unhold

[pedjak]

I assume that ProjectHelmChartRepository is just a namespaced version of HelmChartRepository? If yes, we should keep them in sync, and to avoid large copy/paste blocks, we could do the following:

// +genclient
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +kubebuilder:plural=projecthelmchartrepositories

// ProjectHelmChartRepository holds namespace-wide configuration for proxied Helm chart repository
//
// Compatibility level 2: Stable within a major release for a minimum of 9 months or 3 minor releases (whichever is longer).
// +openshift:compatibility-gen:level=2
type ProjectHelmChartRepository struct {
	metav1.TypeMeta   `json:",inline"`
	metav1.ObjectMeta `json:"metadata,omitempty"`

	// spec holds user settable values for configuration
	// +kubebuilder:validation:Required
	// +required
	Spec HelmChartRepositorySpec `json:"spec"`

	// Observed status of the repository within the namespace..
	// +optional
	Status HelmChartRepositoryStatus `json:"status"`
}

// Compatibility level 2: Stable within a major release for a minimum of 9 months or 3 minor releases (whichever is longer).
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
// +openshift:compatibility-gen:level=2
type ProjectHelmChartRepositoryList struct {
	metav1.TypeMeta `json:",inline"`
	metav1.ListMeta `json:"metadata"`

	Items []ProjectHelmChartRepository `json:"items"`
}

With the above, we can even keep these two structs in `types_helm.go` file, along with the other types.

[pedjak]

/lgtm

[pedjak]

/lgtm

[zonggen]

/assign @knobunc

[spadgett]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, spadgett, zonggen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[debsmita1]

/label docs-approved
/label px-approved

[knobunc]

I think this is more for @bparees than me?

/assign @bparees

[bparees]

this PR is attempting to land post feature freeze, which means it needs to be going through the no-FF process, which in this case means it is awaiting the qe-approved label based on QE testing this feature prior to allowing it to merge.

(of course this PR is only one piece of the feature, so links to the related PRs would help QE w/ that process).

and all that assumes that the team delivering this work is a no-FF process team.

[tisutisu]

Tested this changes with OCP 4.10 dev cluster, Below steps are working fine.

1. Create the CRD

$ oc apply -f helm/v1beta1/0000_10-project-helm-chart-repository.crd.yaml
customresourcedefinition.apiextensions.k8s.io/projecthelmchartrepositories.helm.openshift.io created

$ oc get crd | grep helm
helmchartrepositories.helm.openshift.io                           2022-01-13T07:27:25Z
projecthelmchartrepositories.helm.openshift.io                    2022-01-13T14:38:33Z 

2. Create a CR instance, like in https://github.com/openshift/console/pull/10467/files?short_path=9792ce1#diff-9792ce17aec3657e6f182e08e62ce981cfbcfc33f70cfde0b6f2c40beec672d7

[debsmita1]

Adding the qe approval on @tisutisu 's behalf
/label qe-approved

[openshift-ci]

@zonggen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zonggen]

NOTE: used make generate-with-container to update the deepcopy files.