Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI migration for Azure Disk and Cinder is GA in 4.11 #1115

Merged
merged 1 commit into from Feb 9, 2022
Merged

CSI migration for Azure Disk and Cinder is GA in 4.11 #1115

merged 1 commit into from Feb 9, 2022

Conversation

bertinatto
Copy link
Member

CSI migration for Azure Disk and Cinder will be GA in OCP 4.11.

https://issues.redhat.com/browse/STOR-615
https://issues.redhat.com/browse/STOR-670

CC @openshift/storage

@bertinatto bertinatto changed the title Enable CSI migration for Azure Disk and Cinder CSI migration for Azure Disk and Cinder is GA in 4.11 Feb 4, 2022
@bertinatto
Enable CSI migration for Azure Disk and Cinder
3ad4150 
In 1.24, CSI migration for Azure Disk and Cinder are going to be GA in
upstream Kubernetes. Once that happens, switching off the gates will
not have any effect.
@jsafrane
Copy link
Contributor

jsafrane commented Feb 4, 2022

/lgtm
It corresponds to today's plan (AWS EBS CSI migration GA is uncertain at this point).

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2022

AWS EFS CSI migration GA moved to 1.25: kubernetes/enhancements#3213

Only AzureDisk and Cinder will be GA in 4.11 then.

@deads2k
Copy link
Contributor

deads2k commented Feb 7, 2022

/approve

/hold

holding until @jsafrane wants to merge. Feel free to release whenever.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2022
@jsafrane
Copy link
Contributor

jsafrane commented Feb 8, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@bertinatto
Copy link
Member Author

/test all

@knobunc
Copy link
Contributor

knobunc commented Feb 8, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k, jsafrane, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

I understand we are a "FF team", so:

/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b632c5f into openshift:master Feb 9, 2022
This was referenced Feb 21, 2022
Merged
Merged
@mandre mandre mentioned this pull request Mar 9, 2022
Merged
candita pushed a commit to candita/api that referenced this pull request Mar 23, 2022
@openshift-merge-robot @candita
Merge pull request openshift#1115 from bertinatto/god-help-us
b817dcf 
CSI migration for Azure Disk and Cinder is GA in 4.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bertinatto @jsafrane @deads2k @knobunc @openshift-merge-robot