Bug 1944851: Add selectors to ingress controller status for determining state #1146
Conversation
openshift-ci
bot
added
the
bugzilla/severity-low
|
@gcs278: This pull request references Bugzilla bug 1944851, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
gcs278
force-pushed
the
BZ1944851-Clear-Route-Status
branch
from
04d2f34
to
3635738
Compare
|
/lgtm |
|
/assign @sjenning |
|
/approve |
|
/assign @sjenning |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, gcs278, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@gcs278: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@gcs278: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1944851 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add the routeSelector and namespaceSelector to support route status updates in openshift/cluster-ingress-operator#724 which provide fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1944851 and other bugs indirectly.
These new fields in the status, which are a mirror of the fields in the spec, provide state of the selector allowing us to trigger when either of these selectors are updated.