OCPBUGS-15654: Add MAPI to all capability sets

[qJkee]

For background on the motivation of this change, the baremetal capability set relies on the MachineAPI capability set. Since MachineAPI didn't exist as a capability set in previous releases, the v4.11 through v4.13 capability sets did not include it.
This meant, for a 4.14 onwards install, specifying the v4.13 or lower baseline capability set resulted in a cluster without the MachineAPI, which, on platforms relying on the baremetal capability, would create a non-obvious failure during the installation procedure.
To mitigate this, we add the MachineAPI capability where the baremetal capability is present, allowing the earlier capability sets to continue to be used and produce the same result as in previous releases.

This is also related PRs

1. Add baremetal capability validation installer#7394
2. Ensure baremetal cap is not enabled without MachineAPI cap #1537

[openshift-ci-robot]

@qJkee: This pull request references Jira Issue OCPBUGS-15654, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In order to make capability sets working properly we had to add MAPI capability everywhere where baremetal capability present. We also add api and installer validation to ensure that baremetal and MAPI enabled together, see

1. Add baremetal capability validation installer#7394
2. Ensure baremetal cap is not enabled without MachineAPI cap #1537

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qJkee]

/jira refresh

[openshift-ci-robot]

@qJkee: This pull request references Jira Issue OCPBUGS-15654, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qJkee]

/jira refresh

[openshift-ci-robot]

@qJkee: This pull request references Jira Issue OCPBUGS-15654, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qJkee]

/cc @JoelSpeed @bparees

[openshift-ci]

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/lgtm

This must not be backported to other releases, discussed in slack https://redhat-internal.slack.com/archives/C032HSVS71T/p1691055174729009

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@qJkee: Jira Issue OCPBUGS-15654: All pull requests linked via external trackers have merged:

• openshift/api#1554

Jira Issue OCPBUGS-15654 has been moved to the MODIFIED state.

In response to this:

In order to make capability sets working properly we had to add MAPI capability everywhere where baremetal capability present. We also add api and installer validation to ensure that baremetal and MAPI enabled together, see

1. Add baremetal capability validation installer#7394
2. Ensure baremetal cap is not enabled without MachineAPI cap #1537

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@qJkee: Jira Issue OCPBUGS-15654 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

For background on the motivation of this change, the baremetal capability set relies on the MachineAPI capability set. Since MachineAPI didn't exist as a capability set in previous releases, the v4.11 through v4.13 capability sets did not include it.
This meant, for a 4.14 onwards install, specifying the v4.13 or lower baseline capability set resulted in a cluster without the MachineAPI, which, on platforms relying on the baremetal capability, would create a non-obvious failure during the installation procedure.
To mitigate this, we add the MachineAPI capability where the baremetal capability is present, allowing the earlier capability sets to continue to be used and produce the same result as in previous releases.

This is also related PRs

1. Add baremetal capability validation installer#7394
2. Ensure baremetal cap is not enabled without MachineAPI cap #1537

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.