Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1683055: Add spec and status comments/description for serviceca operator type #276

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Apr 1, 2019

This should resolve: https://bugzilla.redhat.com/show_bug.cgi?id=1683055
testing now

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2019
@sallyom sallyom force-pushed the add-operator-descriptions-spec-status branch from e5f9319 to eb9e88c Compare April 2, 2019 12:14
@sallyom
Copy link
Contributor Author

sallyom commented Apr 10, 2019

@deads2k the bug mentioned here is for oc explain serviceca the descriptions added here are missing in the output. oc explain is currently broken, hopefully will be resolved soon and this PR will resolve the bz.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@openshift-merge-robot openshift-merge-robot merged commit 87f97e6 into openshift:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants