Enable BlockVolume support tech preview for 4.1 #278
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @j-griffith. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold This must be approved via the exception process including PM, architecture, and QE. This expands our test, product, and support surface area. |
openshift-ci-robot
added
the
do-not-merge/hold
config/v1/types_feature.go
Outdated
| @@ -71,6 +71,8 @@ var FeatureSets = map[FeatureSet]*FeatureGateEnabledDisabled{ | |||
| "ExperimentalCriticalPodAnnotation", // sig-pod, sjenning | |||
| "RotateKubeletServerCertificate", // sig-pod, sjenning | |||
| "SupportPodPidsLimit", // sig-pod, sjenning | |||
| "CSIBlockVolume", // sig-storage, j-griffith | |||
| "BlockVolume", // sig-storage, j-griffith | |||
There was a problem hiding this comment.
certainly a NAK on these changes. We are not going to make these available by default out of the box.
There was a problem hiding this comment.
That's certainly fair, I'll remove them from the default set; there was some confusion (on my part) whether they were required to be there or not, I will remove if we can reach agreement on the remaining piece. Thanks!
j-griffith
force-pushed
the
add_csi_block_volume
branch
from
d5096f5
to
3314993
Compare
Add CSIBlockVolume and BlockVolume feature gates to the API.
j-griffith
force-pushed
the
add_csi_block_volume
branch
from
3314993
to
6a702b5
Compare
|
We aren't shipping the CSI shim layers in 4.1 so there's no official CSI block support. This would only be available in-house. Functionally this won't impact other features or be visible to customers. This is low risk +1 for the exception. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, j-griffith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I believe we'll need: |
Add CSIBlockVolume and BlockVolume feature gates to the API. Requesting to add this for support in 4.1 in order to enable planned presentations for RH Summit. Let me know if there is a special feature exception process I need to follow.