Bug 1764224: Update ConsoleCLIDownloads Href validation regexp

[jhadvig]

Per discussion with @spadgett

cc'ing @benjaminapetersen

/assign @bparees

[jhadvig]

@spadgett just to be sure, do we want to relax Href field on the Link struct as well in https://github.com/openshift/api/blob/master/console/v1/types.go#L8 ?

[bparees]

/approve

[spadgett]

@spadgett just to be sure, do we want to relax Href field on the Link struct as well in https://github.com/openshift/api/blob/master/console/v1/types.go#L8 ?

Yes. This is a problem for any console link.

[spadgett]

@jhadvig can you add Bug 1764224: to the PR title? (I don't have permission.)

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1764227, which is invalid:

• expected the bug to target the "4.3.0" release, but it targets "4.2.z" instead
• expected dependent Bugzilla bug 1764224 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1764227: Update ConsoleCLIDownloads Href validation regexp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

@spadgett updated

[spadgett]

Sorry told you the wrong bug number, it should be Bug 1764224

[spadgett]

/retitle Bug 1764224: Update ConsoleCLIDownloads Href validation regexp

forgot about retitle :)

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1764224, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1764224: Update ConsoleCLIDownloads Href validation regexp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/lgtm

[benjaminapetersen]

All of them? Works for me I guess!

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, bparees, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jhadvig: All pull requests linked via external trackers have merged. Bugzilla bug 1764224 has been moved to the MODIFIED state.

In response to this:

Bug 1764224: Update ConsoleCLIDownloads Href validation regexp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.