New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovirt: add a comment about DNS VIP field #684
Conversation
/approve you'll need to regenerate. it's either |
In 4.6, this field is no longer set or honored. See also: openshift/machine-config-operator@c4bf4e4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1846330 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@@ -307,6 +307,12 @@ spec: | |||
type: integer | |||
format: int32 | |||
minimum: 0 | |||
hybridOverlayVXLANPort: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, weird.
@@ -307,6 +307,12 @@ spec: | |||
type: integer | |||
format: int32 | |||
minimum: 0 | |||
hybridOverlayVXLANPort: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@openshift/openshift-team-sdn is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was added recently (#678). I guess some files didn't get regenerated?
That's not awesome. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dougsland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In 4.6, this field is no longer set or honored.
See also:
openshift/machine-config-operator@c4bf4e4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1846330
Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com