Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator/ingress: Add HTTP header name case adjust #793

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Nov 26, 2020

  • operator/v1/types_ingress.go (IngressControllerHTTPHeaderNameCaseAdjustment): New type. Specify an HTTP header name that should have its capitalization adjusted, and how it should be adjusted.
    (IngressControllerHTTPHeaders): Add HeaderNameCaseAdjustments field with type slice of IngressControllerHTTPHeaderNameCaseAdjustment.
  • operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
  • operator/v1/zz_generated.deepcopy.go:
  • operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2020
* operator/v1/types_ingress.go (IngressControllerHTTPHeaderNameCaseAdjustment):
New type.  Specify an HTTP header name that should have its capitalization
adjusted, and how it should be adjusted.
(IngressControllerHTTPHeaders): Add HeaderNameCaseAdjustments field with
type slice of IngressControllerHTTPHeaderNameCaseAdjustment.
* operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
* operator/v1/zz_generated.deepcopy.go:
* operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.
@Miciah Miciah force-pushed the operator-slash-ingress-add-HTTP-header-name-case-adjust branch from c5eb84c to cd3b7d5 Compare November 30, 2020 22:21
@Miciah
Copy link
Contributor Author

Miciah commented Nov 30, 2020

/retitle operator/ingress: Add HTTP header name case adjust

@openshift-ci-robot openshift-ci-robot changed the title WIP: operator/ingress: Add HTTP header name case adjust operator/ingress: Add HTTP header name case adjust Nov 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@deads2k
Copy link
Contributor

deads2k commented Dec 1, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit c6debb3 into openshift:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants