switch to kubernetes 1.16.0-beta.1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
p0lyn0mial
force-pushed
the
bump-to-kubernetes-1-16-0-beta-1
branch
from
e9d64fe
to
1825e53
Compare
|
I run |
p0lyn0mial
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
p0lyn0mial
commented
Aug 30, 2019
| version: v1.14.0 | ||
| version: v1.16.0-beta.1 | ||
| - package: k8s.io/klog | ||
| version: v0.4.0 |
There was a problem hiding this comment.
I had to add this dependency explicitly, otherwise, it failed:
go build ./...
# github.com/openshift/apiserver-library-go/vendor/k8s.io/utils/trace
vendor/k8s.io/utils/trace/trace.go:100:57: invalid operation: stepThreshold == 0 || stepDuration > stepThreshold || klog.V(4) (mismatched types bool and klog.Verbose)
vendor/k8s.io/utils/trace/trace.go:112:56: invalid operation: stepThreshold == 0 || stepDuration > stepThreshold || klog.V(4) (mismatched types bool and klog.Verbose)
# github.com/openshift/apiserver-library-go/vendor/k8s.io/apiserver/pkg/server/httplog
vendor/k8s.io/apiserver/pkg/server/httplog/httplog.go:159:2: non-bool klog.V(3) (type klog.Verbose) used as if condition
vendor/k8s.io/apiserver/pkg/server/httplog/httplog.go:189:9: non-bool klog.V(2) (type klog.Verbose) used as if condition
# github.com/openshift/apiserver-library-go/vendor/k8s.io/client-go/transport
vendor/k8s.io/client-go/transport/round_trippers.go:70:11: cannot convert klog.V(9) (type klog.Verbose) to type bool
vendor/k8s.io/client-go/transport/round_trippers.go:72:11: cannot convert klog.V(8) (type klog.Verbose) to type bool
vendor/k8s.io/client-go/transport/round_trippers.go:74:11: cannot convert klog.V(7) (type klog.Verbose) to type bool
vendor/k8s.io/client-go/transport/round_trippers.go:76:11: cannot convert klog.V(6) (type klog.Verbose) to type bool
There was a problem hiding this comment.
I think upstream uses the same version - kubernetes/apiserver@785eacb#diff-37aff102a57d3d7b797f152915a6dc16R59
p0lyn0mial
commented
Aug 30, 2019
| # openshift second | ||
| - package: github.com/openshift/api | ||
| version: master | ||
| version: prebase-1.16 |
There was a problem hiding this comment.
this will change in the near future to prebase-1.16.0-beta.1
p0lyn0mial
commented
Aug 30, 2019
| @@ -61,7 +61,7 @@ func (d *sccExecRestrictions) Validate(a admission.Attributes, o admission.Objec | |||
|
|
|||
| // TODO, if we want to actually limit who can use which service account, then we'll need to add logic here to make sure that | |||
| // we're allowed to use the SA the pod is using. Otherwise, user-A creates pod and user-B (who can't use the SA) can exec into it. | |||
| createAttributes := admission.NewAttributesRecord(internalPod, nil, coreapi.Kind("Pod").WithVersion(""), a.GetNamespace(), a.GetName(), a.GetResource(), "", admission.Create, false, a.GetUserInfo()) | |||
| createAttributes := admission.NewAttributesRecord(internalPod, nil, coreapi.Kind("Pod").WithVersion(""), a.GetNamespace(), a.GetName(), a.GetResource(), "", admission.Create, a.GetOperationOptions(), false, a.GetUserInfo()) | |||
There was a problem hiding this comment.
I think it is correct, based on kubernetes/kubernetes#77563
There was a problem hiding this comment.
It wires through the field manager (of a pod) and dry run options. I tend to erase the dryrun options.
There was a problem hiding this comment.
Seems like it's better wire through than to snip them.
There was a problem hiding this comment.
passing ExecOptions (or what it is called) to a create admissoin is wrong. This is an artificial admission call.
openshift-ci-robot
added
lgtm
p0lyn0mial
force-pushed
the
bump-to-kubernetes-1-16-0-beta-1
branch
from
7b50f4a
to
1825e53
Compare
p0lyn0mial
force-pushed
the
bump-to-kubernetes-1-16-0-beta-1
branch
from
1825e53
to
1799493
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.