Bug 1970331: pkg/securitycontextconstraints: wait for MCS/UID labels on namespaces, bump verbosity on errors

[s-urbaniak]

/cc @stlaz @deads2k

[s-urbaniak]

/bugzilla refresh

[openshift-ci]

@s-urbaniak: This pull request references Bugzilla bug 1970331, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s-urbaniak]

/bugzilla refresh

[openshift-ci]

@s-urbaniak: An error was encountered querying GitHub for users with public email (liyao@redhat.com) for bug 1970331 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@s-urbaniak: This pull request references Bugzilla bug 1970331, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1970331: pkg/securitycontextconstraints: wait for MCS/UID labels on namespaces, bump verbosity on errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s-urbaniak]

/bugzilla refresh

[openshift-ci]

@s-urbaniak: This pull request references Bugzilla bug 1970331, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liyao@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stlaz]

nits

[deads2k]

This looks like a solid idea. Great find. I'll leave the detailed review and lgtm to

/assign @stlaz
/approve

[stlaz]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@s-urbaniak: All pull requests linked via external trackers have merged:

• openshift/apiserver-library-go#66

Bugzilla bug 1970331 has been moved to the MODIFIED state.

In response to this:

Bug 1970331: pkg/securitycontextconstraints: wait for MCS/UID labels on namespaces, bump verbosity on errors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s-urbaniak]

/cherry-pick release-4.9

[s-urbaniak]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@s-urbaniak: #66 failed to apply on top of branch "release-4.9":

Applying: pkg/securitycontextconstraints: bump verbosity level in case of errors
Applying: pkg/securitycontextconstraints: wait for namespaces and MCS/UID labels
Applying: pkg/securitycontextconstraints/sccadmission: wire context
Using index info to reconstruct a base tree...
M	pkg/securitycontextconstraints/sccadmission/admission.go
M	pkg/securitycontextconstraints/sccadmission/admission_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/securitycontextconstraints/sccadmission/admission_test.go
Auto-merging pkg/securitycontextconstraints/sccadmission/admission.go
CONFLICT (content): Merge conflict in pkg/securitycontextconstraints/sccadmission/admission.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 pkg/securitycontextconstraints/sccadmission: wire context
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@s-urbaniak: #66 failed to apply on top of branch "release-4.8":

Applying: pkg/securitycontextconstraints: bump verbosity level in case of errors
Applying: pkg/securitycontextconstraints: wait for namespaces and MCS/UID labels
Applying: pkg/securitycontextconstraints/sccadmission: wire context
Using index info to reconstruct a base tree...
M	pkg/securitycontextconstraints/sccadmission/admission.go
M	pkg/securitycontextconstraints/sccadmission/admission_test.go
M	pkg/securitycontextconstraints/sccmatching/matcher.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/securitycontextconstraints/sccmatching/matcher.go
Auto-merging pkg/securitycontextconstraints/sccadmission/admission_test.go
Auto-merging pkg/securitycontextconstraints/sccadmission/admission.go
CONFLICT (content): Merge conflict in pkg/securitycontextconstraints/sccadmission/admission.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 pkg/securitycontextconstraints/sccadmission: wire context
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.