Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-204: Multi-arch support for OCP build #356

Conversation

pawanpinjarkar
Copy link
Contributor

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2022
@openshift-ci openshift-ci bot requested review from danielerez and empovit May 19, 2022 00:46
@openshift-ci openshift-ci bot added the downstream-change-needed Requires updating downstream image label May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #356 (6648586) into master (43e9639) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 6648586 differs from pull request most recent head 0ef8a64. Consider uploading reports for the commit 0ef8a64 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   64.17%   64.08%   -0.10%     
==========================================
  Files          49       49              
  Lines        2515     2514       -1     
==========================================
- Hits         1614     1611       -3     
- Misses        789      790       +1     
- Partials      112      113       +1     
Impacted Files Coverage Δ
src/inventory/bmc.go 84.44% <0.00%> (-2.23%) ⬇️
src/commands/actions/next_step_runner.go 89.47% <0.00%> (-0.27%) ⬇️

@pawanpinjarkar pawanpinjarkar force-pushed the multi-arch-support-for-ocp-build branch from 2648f99 to bbc5897 Compare May 19, 2022 01:01
@pawanpinjarkar
Copy link
Contributor Author

Local testing result
Screenshot from 2022-05-18 21 03 31

Dockerfile.ocp Outdated Show resolved Hide resolved
@empovit
Copy link
Contributor

empovit commented May 19, 2022

/uncc empovit

@openshift-ci openshift-ci bot removed the request for review from empovit May 19, 2022 11:08
@pawanpinjarkar pawanpinjarkar force-pushed the multi-arch-support-for-ocp-build branch from bbc5897 to e02354c Compare May 19, 2022 19:34
Dockerfile.ocp Outdated Show resolved Hide resolved
@celebdor
Copy link
Contributor

I agree that the variable is not useful in the way it is done. It doesn't hurt either...
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@lranjbar
Copy link
Contributor

I agree with the nit. I think this is alright for now since we have a larger problem it seems in assisted-service.

/approve

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels May 19, 2022
@lranjbar
Copy link
Contributor

/retest

@osherdp
Copy link
Contributor

osherdp commented May 24, 2022

/hold

/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@pawanpinjarkar pawanpinjarkar force-pushed the multi-arch-support-for-ocp-build branch from 6648586 to 0ef8a64 Compare May 25, 2022 14:00
@pawanpinjarkar
Copy link
Contributor Author

/hold

/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file

@osherdp Fixed the typo now. PTAL. TY.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lranjbar, osherdp, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2022

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lranjbar
Copy link
Contributor

/remove-downstream-change-needed

@lranjbar lranjbar removed the downstream-change-needed Requires updating downstream image label May 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit dd1b1b3 into openshift:master May 25, 2022
@pawanpinjarkar pawanpinjarkar deleted the multi-arch-support-for-ocp-build branch May 25, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants