-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-204: Multi-arch support for OCP build #356
AGENT-204: Multi-arch support for OCP build #356
Conversation
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 64.17% 64.08% -0.10%
==========================================
Files 49 49
Lines 2515 2514 -1
==========================================
- Hits 1614 1611 -3
- Misses 789 790 +1
- Partials 112 113 +1
|
2648f99
to
bbc5897
Compare
/uncc empovit |
bbc5897
to
e02354c
Compare
I agree that the variable is not useful in the way it is done. It doesn't hurt either... |
I agree with the nit. I think this is alright for now since we have a larger problem it seems in assisted-service. /approve |
/retest |
/hold
|
6648586
to
0ef8a64
Compare
@osherdp Fixed the typo now. PTAL. TY. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lranjbar, osherdp, pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/remove-downstream-change-needed |
Ref: https://issues.redhat.com/browse/AGENT-204