New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-12139: Revert disk_speed_check related changes #441
Conversation
This reverts commit 5844216.
…penshift#427)" This reverts commit 3f0e7e2.
Skipping CI for Draft Pull Request. |
/test all |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: javipolo, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 62.62% 62.61% -0.02%
==========================================
Files 56 56
Lines 3010 3009 -1
==========================================
- Hits 1885 1884 -1
Misses 984 984
Partials 141 141
|
@javipolo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Revert "MGMT-12139: Add offset to FIO disk speed check (openshift#437)" This reverts commit 5844216. * Revert "MGMT-11885: disk_speed_check: escape colons when calling fio (openshift#427)" This reverts commit 3f0e7e2.
Running
fio
the way we do creates problems with the cleanupDevice of the assisted-installerLet's revert the changes until we find a proper solution