Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-12139: Revert disk_speed_check related changes #441

Merged
merged 2 commits into from Oct 3, 2022

Conversation

javipolo
Copy link
Member

@javipolo javipolo commented Oct 3, 2022

Running fio the way we do creates problems with the cleanupDevice of the assisted-installer

Let's revert the changes until we find a proper solution

@javipolo javipolo changed the title MGMT-12139: Revert disk_speed_ch MGMT-12139: Revert disk_speed_check related changes Oct 3, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2022
@osherdp
Copy link
Contributor

osherdp commented Oct 3, 2022

/test all

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javipolo, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #441 (921b067) into master (5844216) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   62.62%   62.61%   -0.02%     
==========================================
  Files          56       56              
  Lines        3010     3009       -1     
==========================================
- Hits         1885     1884       -1     
  Misses        984      984              
  Partials      141      141              
Impacted Files Coverage Δ
src/disk_speed_check/disk_speed_check.go 85.33% <100.00%> (-0.20%) ⬇️

@javipolo javipolo marked this pull request as ready for review October 3, 2022 16:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2022

@javipolo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3f83213 into openshift:master Oct 3, 2022
@javipolo javipolo deleted the revertFIO branch October 3, 2022 17:50
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
* Revert "MGMT-12139: Add offset to FIO disk speed check (openshift#437)"

This reverts commit 5844216.

* Revert "MGMT-11885: disk_speed_check: escape colons when calling fio (openshift#427)"

This reverts commit 3f0e7e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants