Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-13665: Bring full journal by default in log gather #492

Merged

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Feb 14, 2023

Currently our default for journal logs is 5 hours though we need to bring full journal logs as sometimes relevant issue is coming day before

Currently our default for journal logs is 5 hours though
we need to bring full journal logs as sometimes relevant issue is coming day before
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2023

@tsorya: This pull request references MGMT-13665 which is a valid jira issue.

In response to this:

Currently our default for journal logs is 5 hours though we need to bring full journal logs as sometimes relevant issue is coming day before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@paul-maidment
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac9ff4b and 2 for PR HEAD dafcc10 in total

@omertuc
Copy link
Contributor

omertuc commented Feb 14, 2023

/lgtm

@tsorya
Copy link
Contributor Author

tsorya commented Feb 14, 2023

/retest-required

@tsorya
Copy link
Contributor Author

tsorya commented Feb 15, 2023

/retest

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #492 (dafcc10) into master (ac9ff4b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   60.28%   60.30%   +0.02%     
==========================================
  Files          70       70              
  Lines        3457     3459       +2     
==========================================
+ Hits         2084     2086       +2     
  Misses       1225     1225              
  Partials      148      148              
Impacted Files Coverage Δ
src/logs_sender/send_logs.go 35.89% <100.00%> (+0.55%) ⬆️

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

@tsorya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d8599f3 into openshift:master Feb 15, 2023
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
Currently our default for journal logs is 5 hours though
we need to bring full journal logs as sometimes relevant issue is coming day before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants