Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-594: remove agent based installer code #563

Conversation

andfasano
Copy link
Contributor

This patch removes all the code (and vendored dependencies) related to the agent-based installer (to ship the agent-tui).

Requires openshift/release#40513 (where the CI part was cleaned up)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 21, 2023

@andfasano: This pull request references AGENT-594 which is a valid jira issue.

In response to this:

This patch removes all the code (and vendored dependencies) related to the agent-based installer (to ship the agent-tui).

Requires openshift/release#40513 (where the CI part was cleaned up)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2023
@openshift-ci openshift-ci bot requested review from nmagnezi and tsorya June 21, 2023 13:30
@pawanpinjarkar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #563 (066aac9) into master (3e6d84c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   60.66%   60.66%           
=======================================
  Files          70       70           
  Lines        3529     3529           
=======================================
  Hits         2141     2141           
  Misses       1236     1236           
  Partials      152      152           

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

/assign @osherdp

openshift/release#40513 landed, so we could proceed with this PR now

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@andfasano
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5acaef1 into openshift:master Jun 22, 2023
11 checks passed
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
* Remove agent-based installer related code

* Removed vendored dependencies related to the agent-based installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants