Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15809: change base image to stream9 #604

Merged

Conversation

osherdp
Copy link
Contributor

@osherdp osherdp commented Sep 19, 2023

Now that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the assisted-service, because installation of nmstate packages either requires entitlements running on a RHEL node, or alternatively an access to RedHat's internal network (which can be a major problem for U/S development). For a better consistency we're sticking with the same for the agent, installer, etc.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023

@osherdp: This pull request references MGMT-15809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

ow that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the assisted-service, because installation of nmstate packages either requires entitlements running on a RHEL node, or alternatively an access to RedHat's internal network (which can be a major problem for U/S development). For a better consistency we're sticking with the same for the agent, installer, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023

@osherdp: This pull request references MGMT-15809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Now that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the assisted-service, because installation of nmstate packages either requires entitlements running on a RHEL node, or alternatively an access to RedHat's internal network (which can be a major problem for U/S development). For a better consistency we're sticking with the same for the agent, installer, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp osherdp marked this pull request as ready for review September 19, 2023 17:59
@osherdp
Copy link
Contributor Author

osherdp commented Sep 19, 2023

/hold
syncing with D/S changes

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #604 (ca32636) into master (8850b6c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   61.02%   61.02%           
=======================================
  Files          70       70           
  Lines        3584     3584           
=======================================
  Hits         2187     2187           
  Misses       1244     1244           
  Partials      153      153           

@osherdp
Copy link
Contributor Author

osherdp commented Sep 20, 2023

/test edge-subsystem-test

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Sep 20, 2023

/test edge-subsystem-test

@osherdp osherdp force-pushed the feature/move-to-rhel9 branch 2 times, most recently from abfb9df to 1b6c9b6 Compare September 21, 2023 08:14
@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/retest

@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/test all

@osherdp osherdp closed this Sep 21, 2023
@osherdp osherdp reopened this Sep 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2023

@osherdp: This pull request references MGMT-15809 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Now that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the assisted-service, because installation of nmstate packages either requires entitlements running on a RHEL node, or alternatively an access to RedHat's internal network (which can be a major problem for U/S development). For a better consistency we're sticking with the same for the agent, installer, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/retest

@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/test all

@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/test all

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Sep 21, 2023

/test all

@osherdp
Copy link
Contributor Author

osherdp commented Sep 26, 2023

/test e2e-agent-compact-ipv4

@osherdp
Copy link
Contributor Author

osherdp commented Sep 27, 2023

/test edge-subsystem-test

@osherdp
Copy link
Contributor Author

osherdp commented Sep 27, 2023

/test e2e-agent-compact-ipv4

@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

mce-images will get fixed with openshift/release#43781

@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/cc @adriengentil

@@ -238,7 +238,7 @@ func startTcpDump(output chan string, ifaceName string, timeoutSecs, count int)
if count > 0 {
countStr = fmt.Sprintf("-c %d", count)
}
dump := fmt.Sprintf("timeout %d tcpdump -l -i %s %s -v 'udp dst port 67' | awk '/DHCP-Message Option 53/{print $6}'", timeoutSecs, ifaceName, countStr)
dump := fmt.Sprintf("timeout %d tcpdump -l -i %s %s -v 'udp dst port 67' | awk '/DHCP-Message \\(53\\)/{print $5}'", timeoutSecs, ifaceName, countStr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ! 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be nice to tee tcpdump results in a file and put it in the artifacts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a great idea, but it will require some extra coding (as I don't think we currently support transferring artifacts from the skipper container to the outside host)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's what I guessed, we can do it later in a follow up work

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/retest

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/retest

Now that D/S building system fully supports RHEL-9 base images (and
allows easy installation of nmstate and other libs that were previously
unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the
assisted-service, because installation of nmstate packages either
requires entitlements running on a RHEL node, or alternatively an access
to RedHat's internal network (which can be a major problem for
U/S development). For a better consistency we're sticking with the same
for the agent, installer, etc.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

github.com/containers/image/v5@v5.20.0: stream error: stream ID 4253; INTERNAL_ERROR; received from peer

not sure what this is about, maybe a minor connectivity issue
/test edge-subsystem-test

@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/retest

@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/test edge-e2e-metal-assisted

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp
Copy link
Contributor Author

osherdp commented Sep 28, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 23226d0 into openshift:master Sep 28, 2023
10 checks passed
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
Now that D/S building system fully supports RHEL-9 base images (and
allows easy installation of nmstate and other libs that were previously
unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S for the
assisted-service, because installation of nmstate packages either
requires entitlements running on a RHEL node, or alternatively an access
to RedHat's internal network (which can be a major problem for
U/S development). For a better consistency we're sticking with the same
for the agent, installer, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants