Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15900: Add enable-skip-mco-reboot flag to assisted installer install command #614

Merged
merged 1 commit into from Oct 11, 2023

Conversation

ori-amizur
Copy link
Contributor

This flag is passed in the assisted service install command and should pass to the assisted installer

/cc @filanov

…tall command

This flag is passed in the assisted service install command and should
pass to the assisted installer
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 11, 2023

@ori-amizur: This pull request references MGMT-15900 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This flag is passed in the assisted service install command and should pass to the assisted installer

/cc @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from filanov October 11, 2023 03:37
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #614 (ba4e55a) into master (baf26cf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   61.07%   61.09%   +0.02%     
==========================================
  Files          70       70              
  Lines        3584     3586       +2     
==========================================
+ Hits         2189     2191       +2     
  Misses       1243     1243              
  Partials      152      152              
Files Coverage Δ
src/commands/actions/install_cmd.go 91.24% <100.00%> (+0.12%) ⬆️

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD baf26cf and 2 for PR HEAD ba4e55a in total

@ori-amizur
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit ad4d28e into openshift:master Oct 11, 2023
10 checks passed
danielerez added a commit to danielerez/assisted-installer-agent that referenced this pull request Oct 16, 2023
paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
…tall command (openshift#614)

This flag is passed in the assisted service install command and should
pass to the assisted installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants