Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15860: add strictfipsruntime to build #629

Merged
merged 1 commit into from Nov 27, 2023

Conversation

rccrdpccl
Copy link
Contributor

this build tag would enable FIPS or Die functionality in binaries

/cc @adriengentil

Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023

@rccrdpccl: This pull request references MGMT-15860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.15." or "openshift-4.15.", but it targets "ACM 2.9.0" instead.

In response to this:

this build tag would enable FIPS or Die functionality in binaries

/cc @adriengentil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #629 (fcd369e) into master (7213119) will increase coverage by 0.12%.
Report is 6 commits behind head on master.
The diff coverage is 68.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   60.40%   60.52%   +0.12%     
==========================================
  Files          74       74              
  Lines        3624     3653      +29     
==========================================
+ Hits         2189     2211      +22     
- Misses       1282     1287       +5     
- Partials      153      155       +2     
Files Coverage Δ
src/inventory/boot.go 100.00% <100.00%> (ø)
src/inventory/system_vendor.go 83.63% <60.86%> (-16.37%) ⬇️

... and 1 file with indirect coverage changes

@adriengentil
Copy link
Contributor

/test edge-publish-multi-arch-images-dry-run

@rccrdpccl
Copy link
Contributor Author

/test edge-subsystem-test

@adriengentil
Copy link
Contributor

/retest

2 similar comments
@rccrdpccl
Copy link
Contributor Author

/retest

@rccrdpccl
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Nov 27, 2023

@rccrdpccl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95fa92e into openshift:master Nov 27, 2023
11 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-node-agent-container-v4.15.0-202311272131.p0.g95fa92e.assembly.stream for distgit ose-agent-installer-node-agent.
All builds following this will include this PR.

paul-maidment pushed a commit to paul-maidment/assisted-installer-agent that referenced this pull request Jan 24, 2024
Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants