Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: subsystem test failing due image format version #677

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Apr 1, 2024

when pulling the image using Docker it create a validation error

> docker pull quay.io/aptible/hello-world                                                                                     
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of qua
y.io/aptible/hello-world:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/ 

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci-robot
Copy link

@eifrach: This pull request explicitly references no jira issue.

In response to this:

when pulling the image using Docker it create a validation error

> docker pull quay.io/aptible/hello-world                                                                                     
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of qua
y.io/aptible/hello-world:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/ 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.54%. Comparing base (d8a3cc5) to head (8fd847c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   60.48%   60.54%   +0.05%     
==========================================
  Files          74       74              
  Lines        3662     3662              
==========================================
+ Hits         2215     2217       +2     
+ Misses       1290     1289       -1     
+ Partials      157      156       -1     

see 1 file with indirect coverage changes

@paul-maidment
Copy link
Contributor

/retest

2 similar comments
@danmanor
Copy link
Contributor

danmanor commented Apr 3, 2024

/retest

@eifrach
Copy link
Contributor Author

eifrach commented Apr 3, 2024

/retest

@danmanor
Copy link
Contributor

danmanor commented Apr 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
Copy link

openshift-ci bot commented Apr 3, 2024

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 645a980 into openshift:master Apr 3, 2024
10 checks passed
@eifrach
Copy link
Contributor Author

eifrach commented Apr 8, 2024

/cherry-pick release-ocm-2.8
/cherry-pick release-ocm-2.9
/cherry-pick release-ocm-2.10

@openshift-cherrypick-robot

@eifrach: new pull request created: #680

In response to this:

/cherry-pick release-ocm-2.8
/cherry-pick release-ocm-2.9
/cherry-pick release-ocm-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eifrach
Copy link
Contributor Author

eifrach commented Apr 8, 2024

/cherry-pick release-ocm-2.9

@eifrach
Copy link
Contributor Author

eifrach commented Apr 8, 2024

/cherry-pick release-ocm-2.10

@openshift-cherrypick-robot

@eifrach: new pull request created: #681

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@eifrach: new pull request created: #682

In response to this:

/cherry-pick release-ocm-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danmanor
Copy link
Contributor

danmanor commented Apr 9, 2024

/cherry-pick release-ocm-2.7

@openshift-cherrypick-robot

@danmanor: new pull request created: #684

In response to this:

/cherry-pick release-ocm-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants