OCPBUGS-31423: Try to pull installer image before installing #679
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@CrystalChun: This pull request references Jira Issue OCPBUGS-31423, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 60.48% 60.04% -0.44%
==========================================
Files 74 74
Lines 3662 3692 +30
==========================================
+ Hits 2215 2217 +2
- Misses 1290 1319 +29
+ Partials 157 156 -1
|
| return err | ||
| } | ||
|
|
||
| func pullImage(pullTimeoutSeconds int64, image string) error { |
There was a problem hiding this comment.
Lets validate if image exists beforehand, another way we will pull it all the time
There was a problem hiding this comment.
Good idea! Added it!
https://issues.redhat.com/browse/OCPBUGS-31423 Split the install command into two parts: pulling the installer image then running the install command. Pulling separately and ahead of time prevents possible flakes when pulling the image. Mostly relevant for day 2 hosts since we don't run the container image availability command before installing.
CrystalChun
force-pushed
the
OCPBUGS-31423
branch
from
a71cf01
to
50dcef8
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@CrystalChun: This pull request references Jira Issue OCPBUGS-31423, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (gamado@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
Oh @tsorya may I get your approval? 😄 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@CrystalChun: Jira Issue OCPBUGS-31423: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-31423 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-node-agent-container-v4.16.0-202404090113.p0.ga7a0bc0.assembly.stream.el9 for distgit ose-agent-installer-node-agent. |
https://issues.redhat.com/browse/OCPBUGS-31423
Split the install command into two parts: pulling the installer image then running the install command. Pulling separately and ahead of time prevents possible flakes when pulling the image. Mostly relevant for day 2 hosts since we don't run the container image availability command before installing.
/cc @tsorya