Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ocm-2.3] Bug 1973117: Add support to create manifest in assisted-installer #311

Merged
merged 1 commit into from Jun 21, 2021
Merged

[ocm-2.3] Bug 1973117: Add support to create manifest in assisted-installer #311

merged 1 commit into from Jun 21, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #271

/assign pkliczewski

@machacekondra
MGMT-4668: Add support to create manifest in assisted-installer
9ab97fe 
This PR add a possibility to create manifests from assisted-installer.
In some cases it may be useful to create manifest from
assisted-isntaller instead of openshift-installer. For example when
installing CNV/LSO/OCS we need to have predefined CRDs for the
operators, because at the time of the operator is being created the CRDs
are not yet created by the OLM.

This PR add support to read the files from custom_manifests.yaml which is retrieved
from the assisted-service. The manifest are created via oc create -f command,
using the kubeconfig-noingress file.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2021
Merged
@openshift-ci openshift-ci bot requested review from eranco74 and filanov June 17, 2021 12:07
@filanov
Copy link
Contributor

filanov commented Jun 20, 2021

/assign @tsorya

eranco74
eranco74 reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2021
@eranco74 eranco74 changed the title [ocm-2.3] MGMT-4668: Add support to create manifest in assisted-installer [ocm-2.3] Bug 1973117: Add support to create manifest in assisted-installer Jun 21, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1973117, which is valid.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1966174 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lalon@redhat.com), skipping review request.

In response to this:

[ocm-2.3] Bug 1973117: Add support to create manifest in assisted-installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c2b1082 into openshift:ocm-2.3 Jun 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1973117 has been moved to the MODIFIED state.

In response to this:

[ocm-2.3] Bug 1973117: Add support to create manifest in assisted-installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lranjbar added a commit to lranjbar/assisted-installer that referenced this pull request Jun 29, 2021
@lranjbar
NO-ISSUE Fix build error created when PR openshift#311 merged
987ed5e 
Signed-off-by: Lisa Rashidi-Ranjbar <lranjbar@redhat.com>
@lranjbar lranjbar mentioned this pull request Jun 29, 2021
Merged
YuviGold added a commit that referenced this pull request Jun 29, 2021
@YuviGold
Merge pull request #318 from lranjbar/fix-installer-build-error
11fc36c 
NO-ISSUE Fix build error created when PR #311 merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

@filanov filanov Awaiting requested review from filanov

Assignees

@pkliczewski pkliczewski

@eranco74 eranco74

@tsorya tsorya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @filanov @eranco74 @pkliczewski @tsorya @openshift-merge-robot @machacekondra