Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: In case must-gather upload failed but logs were gathered already we should retry only upload part #487

Merged
merged 1 commit into from Jun 27, 2022
Merged

NO-ISSUE: In case must-gather upload failed but logs were gathered already we should retry only upload part #487

merged 1 commit into from Jun 27, 2022

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Jun 26, 2022

NO-ISSUE: In case must-gather upload failed but logs were gathered already we should retry only upload part

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2022
@openshift-ci openshift-ci bot requested review from carbonin and flaper87 June 26, 2022 11:18
@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsorya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2022
omertuc
omertuc reviewed Jun 26, 2022
View reviewed changes
Copy link
Contributor

@omertuc omertuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited

Codecov Report

Merging #487 (3c98403) into master (9a6e300) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   48.70%   48.68%   -0.02%     
==========================================
  Files          13       13              
  Lines        2616     2617       +1     
==========================================
  Hits         1274     1274              
  Misses       1211     1211              
- Partials      131      132       +1
Impacted Files Coverage Δ
src/ops/ops.go 2.95% <0.00%> (+<0.01%) ⬆️
...taller_controller/assisted_installer_controller.go 71.56% <50.00%> (-0.20%) ⬇️

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 9a6e300 and 8 for PR HEAD df8fdc7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 9a6e300 and 7 for PR HEAD df8fdc7 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9a6e300 and 6 for PR HEAD df8fdc7 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2022
@omertuc
Copy link
Contributor

omertuc commented Jun 26, 2022

/lgtm

@omertuc
Copy link
Contributor

omertuc commented Jun 26, 2022

/hold until @slaviered and @tsorya agree

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 26, 2022
@tsorya
Copy link
Contributor Author

tsorya commented Jun 27, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
@flaper87
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2022

@tsorya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 9384361 into openshift:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc omertuc left review comments

@slaviered slaviered slaviered left review comments

@carbonin carbonin Awaiting requested review from carbonin

@flaper87 flaper87 Awaiting requested review from flaper87

Assignees

@flaper87 flaper87

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tsorya @openshift-ci-robot @omertuc @flaper87 @slaviered