Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17252: Bump golang.org/x/net/html #695

Merged
merged 1 commit into from Aug 7, 2023

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Aug 7, 2023

Bump golang.org/x/net/html

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 7, 2023
@openshift-ci-robot
Copy link

@danmanor: This pull request references Jira Issue OCPBUGS-17252, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.7.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump golang.org/x/net/html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 7, 2023
@danmanor
Copy link
Contributor Author

danmanor commented Aug 7, 2023

/cc @osherdp

@openshift-ci openshift-ci bot requested a review from osherdp August 7, 2023 11:15
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #695 (47f24bf) into master (4ca9441) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   54.68%   54.68%           
=======================================
  Files          14       14           
  Lines        2911     2911           
=======================================
  Hits         1592     1592           
  Misses       1177     1177           
  Partials      142      142           

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp osherdp removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 785d23c into openshift:master Aug 7, 2023
10 checks passed
@openshift-ci-robot
Copy link

@danmanor: Jira Issue OCPBUGS-17252 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bump golang.org/x/net/html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants