OCPBUGS-16482: bump golangci-lint to 1.53.1

[rwsu]

Cannot update golangci-lint in the same PR as one exhibiting issues because the CI still uses the previous version.

Updating k8s.io/apimachinery module to a newer version causes the old linter to throw nil pointer error.

Example #701

[openshift-ci-robot]

@rwsu: This pull request references Jira Issue OCPBUGS-16482, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cannot update golangci-lint in the same PR as one exhibiting issues because the CI still uses the previous version.

Updating k8s.io/apimachinery module to a newer version causes the old linter to throw nil pointer error.

Example #701

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #702 (d405662) into master (fd3e8f3) will increase coverage by 3.09%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   54.68%   57.78%   +3.09%     
==========================================
  Files          14       14              
  Lines        2911     3326     +415     
==========================================
+ Hits         1592     1922     +330     
- Misses       1177     1241      +64     
- Partials      142      163      +21     

see 2 files with indirect coverage changes

[rwsu]

/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osherdp, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD deee07c and 2 for PR HEAD d405662 in total

[openshift-ci]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rwsu: Jira Issue OCPBUGS-16482: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/assisted-installer#701 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-16482 has not been moved to the MODIFIED state.

In response to this:

Cannot update golangci-lint in the same PR as one exhibiting issues because the CI still uses the previous version.

Updating k8s.io/apimachinery module to a newer version causes the old linter to throw nil pointer error.

Example #701

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302