MGMT-15810: fix image missing nsenter executable

[osherdp]

It seems like we were missing an explicit installation for the nsenter executable which does not exist by default in stream9 base image.

The resulting errors are:

level=info msg="failed executing nsenter [--target 1 --cgroup --mount
--ipc --pid -- vgs --noheadings -o vg_name,pv_name], env vars
[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HTTPS_PROXY= http_proxy= NO_PROXY= HTTP_PROXY= TERM=xterm
container=podman BUILD_LOGLEVEL=0
OPENSHIFT_BUILD_NAME=assisted-installer
OPENSHIFT_BUILD_NAMESPACE=ci-op-8g1imlzt https_proxy= no_proxy=
HOME=/root HOSTNAME=test-infra-cluster-3119ce36-master-2], error exec:
\"nsenter\": executable file not found in $PATH, waitStatus 0, Output
\"\""

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-test-infra/2274/pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted/1706886740561629184)

/cc @ori-amizur

[openshift-ci-robot]

@osherdp: This pull request references MGMT-15810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

It seems like we were missing an explicit installation for the nsenter executable which does not exist by default in stream9 base image.

The resulting errors are:

level=info msg="failed executing nsenter [--target 1 --cgroup --mount
--ipc --pid -- vgs --noheadings -o vg_name,pv_name], env vars
[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HTTPS_PROXY= http_proxy= NO_PROXY= HTTP_PROXY= TERM=xterm
container=podman BUILD_LOGLEVEL=0
OPENSHIFT_BUILD_NAME=assisted-installer
OPENSHIFT_BUILD_NAMESPACE=ci-op-8g1imlzt https_proxy= no_proxy=
HOME=/root HOSTNAME=test-infra-cluster-3119ce36-master-2], error exec:
\"nsenter\": executable file not found in $PATH, waitStatus 0, Output
\"\""

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-test-infra/2274/pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted/1706886740561629184)

This also adds this requirement to the controller image, although it doesn't require it at the moment (but the dependency on ops.go means that in the future we might still reuse more functions from that file).

/cc @ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[osherdp]

/hold
waiting for tests

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ori-amizur]

/lgtm

[openshift-ci-robot]

@osherdp: This pull request references MGMT-15810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

It seems like we were missing an explicit installation for the nsenter executable which does not exist by default in stream9 base image.

The resulting errors are:

level=info msg="failed executing nsenter [--target 1 --cgroup --mount
--ipc --pid -- vgs --noheadings -o vg_name,pv_name], env vars
[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HTTPS_PROXY= http_proxy= NO_PROXY= HTTP_PROXY= TERM=xterm
container=podman BUILD_LOGLEVEL=0
OPENSHIFT_BUILD_NAME=assisted-installer
OPENSHIFT_BUILD_NAMESPACE=ci-op-8g1imlzt https_proxy= no_proxy=
HOME=/root HOSTNAME=test-infra-cluster-3119ce36-master-2], error exec:
\"nsenter\": executable file not found in $PATH, waitStatus 0, Output
\"\""

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-test-infra/2274/pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted/1706886740561629184)

/cc @ori-amizur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #729 (4473448) into master (5f09d3a) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files          14       14           
  Lines        2938     2938           
=======================================
  Hits         1592     1592           
  Misses       1203     1203           
  Partials      143      143           

[osherdp]

/test mce-images

[osherdp]

/retest

[eranco74]

/lgtm

[osherdp]

/retest

[osherdp]

/unhold
/remove-label downstream-change-needed

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 15a57d1 and 2 for PR HEAD 4473448 in total

[openshift-ci]

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.