Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16266: Indication event showing how often host has been rebooted missing on some nodes #757

Merged
merged 1 commit into from Dec 11, 2023
Merged

MGMT-16266: Indication event showing how often host has been rebooted missing on some nodes #757

merged 1 commit into from Dec 11, 2023

Conversation

ori-amizur
Copy link
Contributor

There are many possible failures. Many of these failures are temporary such as API is not reachable, or failure to create debug pod. Added retry for the retrieval of number of reboots

/cc @filanov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023 •
edited by openshift-ci bot

@ori-amizur: This pull request references MGMT-16266 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

There are many possible failures. Many of these failures are temporary such as API is not reachable, or failure to create debug pod. Added retry for the retrieval of number of reboots

/cc @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from filanov December 7, 2023 10:09
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 7, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited

Codecov Report

Merging #757 (c26f6c1) into master (81ef854) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 86.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   56.33%   56.33%   -0.01%     
==========================================
  Files          15       15              
  Lines        3220     3236      +16     
==========================================
+ Hits         1814     1823       +9     
- Misses       1241     1246       +5     
- Partials      165      167       +2
Files Coverage Δ
.../assisted_installer_controller/reboots_notifier.go 87.27% <92.30%> (-8.38%) ⬇️
src/utils/utils.go 27.62% <77.77%> (+1.76%) ⬆️

@ori-amizur ori-amizur force-pushed the MGMT-16266 branch 2 times, most recently from 26f7e32 to 85d0357 Compare December 7, 2023 10:39
filanov
filanov reviewed Dec 7, 2023
View reviewed changes
src/assisted_installer_controller/reboots_notifier.go Outdated
)

var getNumRebootsRetrySleepDuration = 15 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why keep it ourside of the const?

Copy link
Contributor Author

@ori-amizur ori-amizur Dec 7, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set it to short duration in unit tests

assisted-installer/src/assisted_installer_controller/reboots_notifier_test.go

Line 39 in 85d0357

getNumRebootsRetrySleepDuration = time.Millisecond

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to const

@ori-amizur
MGMT-16266: Indication event showing how often host has been rebooted…
c26f6c1 
… missing on some nodes

There are many possible failures.  Many of these failures are temporary
such as API is not reachable, or failure to create debug pod.
Added retry for the retrieval of number of reboots
@ori-amizur
Copy link
Contributor Author

/retest

2 similar comments
@ori-amizur
Copy link
Contributor Author

/retest

@ori-amizur
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 81ef854 and 2 for PR HEAD c26f6c1 in total

@ori-amizur
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 02b81be and 1 for PR HEAD c26f6c1 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2023

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 94b7d71 into openshift:master Dec 11, 2023
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-orchestrator-container-v4.16.0-202312120008.p0.g94b7d71.assembly.stream for distgit ose-agent-installer-orchestrator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filanov filanov filanov approved these changes

Assignees

@filanov filanov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ori-amizur @openshift-ci-robot @openshift-bot @filanov