MGMT-16370: fix golangci-lint failing to be pulled #758
Conversation
app-sre made their repo mirroring golangci-lint private for legal reasons, and now our jobs are failing to install it. Installing it now from the cli. We could also have pulled golangci-lint from dockerhub, but rate limitation there is quite aggressive.
openshift-ci-robot
added
the
jira/valid-reference
|
@adriengentil: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
downstream-change-needed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 56.33% 56.33%
=======================================
Files 15 15
Lines 3220 3220
=======================================
Hits 1814 1814
Misses 1241 1241
Partials 165 165 |
|
/retest |
|
/lgtm |
|
/retest |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/remove-label downstream-change-needed |
openshift-ci
bot
removed
the
downstream-change-needed
|
/retitle MGMT-16370: fix golangci-lint failing to be pulled |
openshift-ci
bot
changed the title
|
@adriengentil: This pull request references MGMT-16370 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/edge-e2e-ai-operator-ztp |
|
@adriengentil: Overrode contexts on behalf of adriengentil: ci/prow/edge-e2e-ai-operator-ztp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-csr-approver-container-v4.16.0-202312111950.p0.g02b81be.assembly.stream for distgit ose-agent-installer-csr-approver. |
|
I think this needs to be backported. Older version periodics are still failing on this. |
app-sre made their repo mirroring golangci-lint private for legal reasons, and
now our jobs are failing to install it. Installing it now from the cli.
We could also have pulled golangci-lint from dockerhub, but rate
limitation there is quite aggressive.