MGMT-16966: Problem creating extra partition on main disk in 4.15+ #787
Conversation
When skipping MCO reboot, the last partition is extended to fill the remaining free space in the disk. This may be undesirable since there are scenarios that a user adds a partition in the installation disk. This change doubles the space occupied by the last disk partition instead of occupying all the remining space. The assumption is that doubling the space should be enough for image overwrite.
|
@ori-amizur: This pull request references MGMT-16966 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
size/L
|
what's the behavior in coreos-installer? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
==========================================
+ Coverage 56.27% 56.43% +0.15%
==========================================
Files 15 15
Lines 3316 3358 +42
==========================================
+ Hits 1866 1895 +29
- Misses 1282 1289 +7
- Partials 168 174 +6
|
No change for coreos-installer regarding this change |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: javipolo, ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit 7a2ea37
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-csr-approver-container-v4.16.0-202402211239.p0.g7a2ea37.assembly.stream.el8 for distgit ose-agent-installer-csr-approver. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-orchestrator-container-v4.16.0-202402211239.p0.g7a2ea37.assembly.stream.el8 for distgit ose-agent-installer-orchestrator. |
When skipping MCO reboot, the last partition is extended to fill the remaining free space in the disk. This may be undesirable since there are scenarios that a user adds a partition in the installation disk.
This change doubles the space occupied by the last disk partition instead of occupying all the remining space. The assumption is that doubling the space should be enough for image overwrite.
/cc @javipolo