MGMT-16843: Ensure valid hostname during install #788

CrystalChun · 2024-02-21T19:27:04Z

https://issues.redhat.com/browse/MGMT-16843
Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail.

Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

See above issue for an example of the scenario with an invalid hostname fails to install.

/cc @omertuc @gamli75

openshift-ci-robot · 2024-02-21T19:27:07Z

@CrystalChun: This pull request references MGMT-16843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-16843
Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail.

Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

See above issue for an example of the scenario with an invalid hostname fails to install.

/cc @omertuc @gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-21T19:27:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [CrystalChun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2024-02-21T19:32:55Z

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (7a2ea37) 56.43% compared to head (a3605aa) 56.28%.

❗ Current head a3605aa differs from pull request most recent head 662bf4c. Consider uploading reports for the commit 662bf4c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   56.43%   56.28%   -0.16%     
==========================================
  Files          15       15              
  Lines        3358     3367       +9     
==========================================
  Hits         1895     1895              
- Misses       1289     1295       +6     
- Partials      174      177       +3

Files	Coverage Δ
src/installer/installer.go	`69.29% <60.00%> (-1.04%)`	⬇️

gamli75 · 2024-02-21T21:16:41Z

@CrystalChun please add a test for hostname with Capital letters

gamli75 · 2024-02-21T21:18:59Z

@tsorya please review

https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

tsorya · 2024-02-21T21:49:33Z

src/installer/installer.go

-	if hostname != "localhost" {
-		i.log.Infof("hostname is not localhost, no need to do anything")
+
+	if err := validations.ValidateHostname(hostname); err == nil && hostname != "localhost" {


maybe we can always write requested hostname?
Though this seems fine

tsorya · 2024-02-22T17:03:13Z

/lgtm

CrystalChun · 2024-02-22T19:22:43Z

/cherry-pick release-ocm-2.9

CrystalChun · 2024-02-22T19:22:50Z

/cherry-pick release-ocm-2.8

CrystalChun · 2024-02-22T19:23:07Z

/cherry-pick release-4.15

CrystalChun · 2024-02-22T19:23:11Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2024-02-22T19:23:25Z

@CrystalChun: #788 failed to apply on top of branch "release-ocm-2.9":

Applying: MGMT-16843: Ensure valid hostname during install
Using index info to reconstruct a base tree...
M	src/installer/installer.go
M	src/installer/installer_test.go
Falling back to patching base and 3-way merge...
Auto-merging src/installer/installer_test.go
CONFLICT (content): Merge conflict in src/installer/installer_test.go
Auto-merging src/installer/installer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 MGMT-16843: Ensure valid hostname during install
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2024-02-22T19:23:29Z

@CrystalChun: #788 failed to apply on top of branch "release-ocm-2.8":

Applying: MGMT-16843: Ensure valid hostname during install
Using index info to reconstruct a base tree...
M	src/installer/installer.go
M	src/installer/installer_test.go
Falling back to patching base and 3-way merge...
Auto-merging src/installer/installer_test.go
CONFLICT (content): Merge conflict in src/installer/installer_test.go
Auto-merging src/installer/installer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 MGMT-16843: Ensure valid hostname during install
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2024-02-22T19:23:49Z

@CrystalChun: new pull request created: #791

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2024-02-22T19:23:52Z

@CrystalChun: #788 failed to apply on top of branch "release-4.14":

Applying: MGMT-16843: Ensure valid hostname during install
Using index info to reconstruct a base tree...
M	src/installer/installer.go
M	src/installer/installer_test.go
Falling back to patching base and 3-way merge...
Auto-merging src/installer/installer_test.go
CONFLICT (content): Merge conflict in src/installer/installer_test.go
Auto-merging src/installer/installer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 MGMT-16843: Ensure valid hostname during install
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-22T21:36:36Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-orchestrator-container-v4.16.0-202402222111.p0.g9f1f798.assembly.stream.el8 for distgit ose-agent-installer-orchestrator.
All builds following this will include this PR.

https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

Cherry pick of PR openshift#788 https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

Cherry pick of PR openshift#788 https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

) Cherry pick of PR #788 https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

Cherry pick of PR #788 https://issues.redhat.com/browse/MGMT-16843 Some processes during install time depend on the hostname and an invalid hostname (e.g. 'localhost', having capital letters, etc.) that could cause the install to fail. Extra validation is added when checking the hostname to ensure it is valid. A random hostname will be assigned if the current hostname is invalid.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 21, 2024

openshift-ci bot requested review from gamli75 and omertuc February 21, 2024 19:27

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024

CrystalChun force-pushed the hostname branch from af644c5 to 662bf4c Compare February 21, 2024 21:32

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2024

tsorya reviewed Feb 21, 2024

View reviewed changes

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2024

CrystalChun force-pushed the hostname branch from a3605aa to 662bf4c Compare February 22, 2024 17:02

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024

openshift-ci bot assigned tsorya Feb 22, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024

openshift-merge-bot bot merged commit 9f1f798 into openshift:master Feb 22, 2024
9 of 10 checks passed

openshift-cherrypick-robot mentioned this pull request Feb 22, 2024

[release-4.15] MGMT-17020: Ensure valid hostname during install #791

Merged

CrystalChun mentioned this pull request Feb 23, 2024

[release-ocm-2.9] MGMT-16843: Ensure valid hostname during install #792

Merged

CrystalChun mentioned this pull request Feb 23, 2024

[release-ocm-2.8] MGMT-16843: Ensure valid hostname during install #793

Merged

CrystalChun mentioned this pull request Feb 23, 2024

[release-4.14] MGMT-16843: Ensure valid hostname during install #794

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MGMT-16843: Ensure valid hostname during install #788

MGMT-16843: Ensure valid hostname during install #788

CrystalChun commented Feb 21, 2024

openshift-ci-robot commented Feb 21, 2024 •

edited by openshift-ci bot

openshift-ci bot commented Feb 21, 2024

codecov bot commented Feb 21, 2024 •

edited

gamli75 commented Feb 21, 2024

gamli75 commented Feb 21, 2024

tsorya Feb 21, 2024

tsorya commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-bot commented Feb 22, 2024

MGMT-16843: Ensure valid hostname during install #788

MGMT-16843: Ensure valid hostname during install #788

Conversation

CrystalChun commented Feb 21, 2024

openshift-ci-robot commented Feb 21, 2024 • edited by openshift-ci bot

openshift-ci bot commented Feb 21, 2024

codecov bot commented Feb 21, 2024 • edited

Codecov Report

gamli75 commented Feb 21, 2024

gamli75 commented Feb 21, 2024

tsorya Feb 21, 2024

Choose a reason for hiding this comment

tsorya commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

CrystalChun commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-cherrypick-robot commented Feb 22, 2024

openshift-bot commented Feb 22, 2024

openshift-ci-robot commented Feb 21, 2024 •

edited by openshift-ci bot

codecov bot commented Feb 21, 2024 •

edited