MGMT-17384: Change waiting for encapsulated machine config from retry to wait-for-predicate #807
Conversation
… to wait-for-predicate When the function ops.GetEncapsulatedMC takes too long, the host stage 'Writing image to disk' times out since retry is used. This changes the machanism to timeout instead of retry.
openshift-ci-robot
added
the
jira/valid-reference
|
@ori-amizur: This pull request references MGMT-17384 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
- Coverage 56.48% 56.42% -0.06%
==========================================
Files 15 15
Lines 3385 3385
==========================================
- Hits 1912 1910 -2
- Misses 1295 1296 +1
- Partials 178 179 +1
|
|
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-csr-approver-container-v4.16.0-202404011219.p0.g16d05ab.assembly.stream.el8 for distgit ose-agent-installer-csr-approver. |
When the function ops.GetEncapsulatedMC takes too long, the host stage 'Writing image to disk' times out since retry is used.
This changes the machanism to timeout instead of retry.
/cc @tsorya