Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Decouple inventoryClient from ops #811

Merged
merged 1 commit into from Apr 10, 2024

Conversation

eranco74
Copy link
Contributor

@eranco74 eranco74 commented Apr 9, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2024
@openshift-ci-robot
Copy link

@eranco74: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2024
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.74%. Comparing base (4d2d54b) to head (844432d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   55.45%   54.74%   -0.71%     
==========================================
  Files          16       16              
  Lines        3394     3394              
==========================================
- Hits         1882     1858      -24     
- Misses       1339     1364      +25     
+ Partials      173      172       -1     
Files Coverage Δ
src/coreos_logger/coreos_installer_log_writer.go 0.00% <ø> (ø)
src/installer/installer.go 69.75% <100.00%> (ø)
src/ops/ops.go 44.38% <0.00%> (ø)

Signed-off-by: Eran Cohen <eranco@redhat.com>
Copy link

openshift-ci bot commented Apr 9, 2024

@eranco74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tsorya
Copy link
Contributor

tsorya commented Apr 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 236a7a0 into openshift:master Apr 10, 2024
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-orchestrator-container-v4.16.0-202404100642.p0.g236a7a0.assembly.stream.el8 for distgit ose-agent-installer-orchestrator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants