Skip to content

Commit

Permalink
MGMT-16157 Remove recover usage from DB transactions (#5795)
Browse files Browse the repository at this point in the history
The downside of recover is that it may hide bugs like accessing nil
pointer and can create a situation where a function panic and instead of
returning an error it will return nil, in some cases it cause a hot loop
in our controllers, or just move a bug to an upper later.

To avoid those situations we decided to remove the recover function
usage in the transaction code and move to a new transaction style that
will make scope of the trnasaction and handling of errors clearer.

Fix unit tests

Remove CancelInstallCommitFailedEvent event, it doesn't help the user in any way
  • Loading branch information
filanov committed Dec 12, 2023
1 parent 286c4af commit 005ba71
Show file tree
Hide file tree
Showing 6 changed files with 415 additions and 609 deletions.

0 comments on commit 005ba71

Please sign in to comment.