MGMT-13132: Respond with 409 when rejecting registration (#4858)

Currently when an agent tries to register while the cluster is
installing the service will return a 400 response code. As a result the
agent will retry the request after one minute. To avoid that this patch
changes the response code to 409, which will cause the agent to freeze.

Related: https://issues.redhat.com/browse/MGMT-13132
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>

Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>

internal/bminventory/inventory.go

@@ -4999,7 +4999,7 @@ func (b *bareMetalInventory) V2RegisterHost(ctx context.Context, params installe
 					params.NewHostParams.HostID, params.InfraEnvID.String(), err.Error())
 				eventgen.SendHostRegistrationFailedEvent(ctx, b.eventsHandler, *params.NewHostParams.HostID, params.InfraEnvID, cluster.ID, err.Error())
 
-				return common.NewApiError(http.StatusBadRequest, err)
+				return common.NewApiError(http.StatusConflict, err)
 			}
 		}
 

internal/bminventory/inventory_test.go

@@ -485,7 +485,7 @@ var _ = Describe("RegisterHost", func() {
 		By("verifying returned response")
 		apiErr, ok := reply.(*common.ApiErrorResponse)
 		Expect(ok).Should(BeTrue())
-		Expect(apiErr.StatusCode()).Should(Equal(int32(http.StatusBadRequest)))
+		Expect(apiErr.StatusCode()).Should(Equal(int32(http.StatusConflict)))
 		Expect(apiErr.Error()).Should(Equal(err.Error()))
 	})
 

subsystem/cluster_test.go

@@ -1772,7 +1772,7 @@ var _ = Describe("cluster install", func() {
 					HostID: strToUUID(uuid.New().String()),
 				},
 			})
-			Expect(err).To(BeAssignableToTypeOf(installer.NewV2RegisterHostBadRequest()))
+			Expect(err).To(BeAssignableToTypeOf(installer.NewV2RegisterHostConflict()))
 		})
 
 		It("register host while cluster in error state", func() {
@@ -1786,7 +1786,7 @@ var _ = Describe("cluster install", func() {
 					HostID: strToUUID(uuid.New().String()),
 				},
 			})
-			Expect(err).To(BeAssignableToTypeOf(installer.NewV2RegisterHostBadRequest()))
+			Expect(err).To(BeAssignableToTypeOf(installer.NewV2RegisterHostConflict()))
 		})
 
 		It("fail installation if there is only a single worker that manages to install", func() {