MGMT-14726: Ensure that manifest filename does not contain spaces.

Ensure that in any cases where we are writing or updating a manifest
file that the filename does not contain any spaces.

internal/manifests/manifests.go

@@ -376,11 +376,19 @@ func (m *Manifests) fetchManifestContent(ctx context.Context, clusterID strfmt.U
 
 func (m *Manifests) validateManifestFileNames(ctx context.Context, clusterID strfmt.UUID, fileNames []string) error {
 	for _, fileName := range fileNames {
+		if strings.Contains(fileName, " ") {
+			return m.prepareAndLogError(
+				ctx,
+				http.StatusBadRequest,
+				errors.Errorf("Cluster manifest %s for cluster %s should not include a space in it's name.",
+					fileName,
+					clusterID))
+		}
 		if strings.ContainsRune(fileName, os.PathSeparator) {
 			return m.prepareAndLogError(
 				ctx,
 				http.StatusBadRequest,
-				errors.Errorf("Cluster manifest %s for cluster %s should not include a directory in its name.",
+				errors.Errorf("Cluster manifest %s for cluster %s should not include a directory in it's name.",
 					fileName,
 					clusterID))
 		}

internal/manifests/manifests_test.go

@@ -254,6 +254,23 @@ var _ = Describe("ClusterManifestTests", func() {
 				return fmt.Sprintf("{\"data\":\"%s\"}", largeElementBuilder.String())
 			}
 
+			It("Does not accept a filename that contains spaces", func(){
+				clusterID := registerCluster().ID
+				content := "{}"
+				fileName := "dest FileName"
+				response := manifestsAPI.V2CreateClusterManifest(ctx, operations.V2CreateClusterManifestParams{
+					ClusterID: *clusterID,
+					CreateManifestParams: &models.CreateManifestParams{
+						Content:  &content,
+						FileName: &fileName,
+					},
+				})
+				err := response.(*common.ApiErrorResponse)
+				expectedErrorMessage := fmt.Sprintf("Cluster manifest %s for cluster %s should not include a space in it's name.", fileName, clusterID)
+				Expect(err.StatusCode()).To(Equal(int32(http.StatusBadRequest)))
+				Expect(err.Error()).To(Equal(expectedErrorMessage))
+			})
+
 			It("accepts manifest in json format and .json extension", func() {
 				clusterID := registerCluster().ID
 				jsonContent := encodeToBase64(contentAsJSON)
@@ -417,7 +434,7 @@ spec:
 				Expect(response).Should(BeAssignableToTypeOf(common.NewApiError(http.StatusBadRequest, errors.New(""))))
 				err := response.(*common.ApiErrorResponse)
 				Expect(err.StatusCode()).To(Equal(int32(http.StatusBadRequest)))
-				Expect(err.Error()).To(ContainSubstring("Cluster manifest openshift/99-test.yaml for cluster " + clusterID.String() + " should not include a directory in its name."))
+				Expect(err.Error()).To(ContainSubstring("Cluster manifest openshift/99-test.yaml for cluster " + clusterID.String() + " should not include a directory in it's name."))
 			})
 
 			It("Creation fails for a manifest file that exceeds the maximum upload size", func() {
@@ -637,6 +654,25 @@ spec:
 	})
 
 	Context("UpdateClusterManifest", func() {
+		It("Does not accept a filename that contains spaces", func(){
+			clusterID := registerCluster().ID
+			destFolder := "manifests"
+			destFileName := "dest FileName"
+			response := manifestsAPI.V2UpdateClusterManifest(ctx, operations.V2UpdateClusterManifestParams{
+				ClusterID: *clusterID,
+				UpdateManifestParams: &models.UpdateManifestParams{
+					FileName:        fileNameYaml,
+					Folder:          defaultFolder,
+					UpdatedFolder:   &destFolder,
+					UpdatedFileName: &destFileName,
+				},
+			})
+			err := response.(*common.ApiErrorResponse)
+			expectedErrorMessage := fmt.Sprintf("Cluster manifest %s for cluster %s should not include a space in it's name.", destFileName, clusterID)
+			Expect(err.StatusCode()).To(Equal(int32(http.StatusBadRequest)))
+			Expect(err.Error()).To(Equal(expectedErrorMessage))
+		})
+
 		It("moves existing file from one path to another", func() {
 			clusterID := registerCluster().ID
 			destFolder := "manifests"