Skip to content

Commit

Permalink
NO-ISSUE: Fix DNS wilcard domain validation
Browse files Browse the repository at this point in the history
DNS wildcard domain starts with validateNoWildcardDNS. The domain may have an optional trailing dot.
Currently the assumption is that the trailing dot is mandatory for the domain name.
  • Loading branch information
ori-amizur committed Oct 10, 2023
1 parent 91fcb5b commit c923f6a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/validations/validations.go
Expand Up @@ -18,7 +18,7 @@ import (
const (
baseDomainRegex = `^[a-z\d]+[\-]*[a-z\d]+$`
dnsNameRegex = `^([a-z\d]([\-]*[a-z\d]+)*\.)+[a-z\d]+[\-]*[a-z\d]+$`
wildCardDomainRegex = `^(validateNoWildcardDNS\.).+\.$`
wildCardDomainRegex = `^(validateNoWildcardDNS\.).+\.?$`
hostnameRegex = `^[a-z0-9][a-z0-9\-\.]{0,61}[a-z0-9]$`
installerArgsValuesRegex = `^[A-Za-z0-9@!#$%*()_+-=//.,";':{}\[\]]+$`
)
Expand Down
8 changes: 8 additions & 0 deletions pkg/validations/validations_test.go
Expand Up @@ -264,6 +264,14 @@ var _ = Describe("dns name", func() {
domainName: "exam--ple",
valid: true,
},
{
domainName: "validateNoWildcardDNS.test.com",
valid: true,
},
{
domainName: "validateNoWildcardDNS.test.com.",
valid: true,
},
{
domainName: "a.c",
valid: false,
Expand Down

0 comments on commit c923f6a

Please sign in to comment.