OCPBUGSM-29619 map clusterdeployment to infraenv from all namespaces #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
openshift-ci
bot
requested review from
rollandf and
filanov
and removed request for
avishayt and
eliorerz
|
please change the comment and the title to https://issues.redhat.com/browse/OCPBUGSM-29619 the MGMT-6474 is obsolete |
danielerez
changed the title
danielerez
force-pushed
the
map_infraenv_ns
branch
from
064fed3
to
2c348e1
Compare
filanov
reviewed
May 26, 2021
| @@ -1124,6 +1124,43 @@ var _ = Describe("[kube-api]cluster installation", func() { | |||
| Expect(cluster.ImageGenerated).Should(Equal(true)) | |||
| }) | |||
|
|
|||
| It("deploy infraEnv in default namespace before clusterDeployment", func() { | |||
| // Deploy InfraEnv in default namespace | |||
| err := kubeClient.Create(ctx, &v1beta1.InfraEnv{ | |||
There was a problem hiding this comment.
the cleanup will not remove from a default namespace, please add a defer that remove this after this test is over.
In order to support deploying infraenv CRD before CD/ACI when using a different namespace, list infraenvs from all namespaces.
danielerez
force-pushed
the
map_infraenv_ns
branch
from
2c348e1
to
37528c5
Compare
filanov
approved these changes
May 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support deploying infraenv CRD before CD/ACI
when using a different namespace, list infraenvs from all namespaces.