Bug 1968455: Wait for REST api before starting controllers #1951
Conversation
Currently controllers doesn't take into account the current state of the REST API and can be started before we've uploaded rhcos base image, or before we've validated the pull-secret for auxiliary images (controller, agent, installer). To this PR I added to the controllers initialization section a blocking part that waits for the REST API readiness before continuing.
|
Can one of the admins verify this patch? |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retitle Bug 1968455 Wait for REST api before starting controllers |
openshift-ci
bot
changed the title
|
/retitle Bug 1968455: Wait for REST api before starting controllers |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1968455, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-high
|
/unhlod |
|
/retest opened CI bug https://issues.redhat.com/browse/MGMT-6863 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
|
@ronniel1: This pull request references Bugzilla bug 1968455, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@ronniel1: This pull request references Bugzilla bug 1968455, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 5 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1968455 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1937
/assign RazRegev