New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting #2119
[ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting #2119
Conversation
openshift#2027 added a more precise indication that there is no backend cluster and directs the user to inspect AgentClusterInstall conditions. This PR fixes a formatting issue with that msg, which looked as follows: message: 'Failed to create image: cluster does not exist: single-node, check AgentClusterInstall conditions: &{Group:extensions.hive.openshift.io Version:v1beta1 Kind:AgentClusterInstall Name:test-agent-cluster-install}' With this change: message: 'Failed to create image: cluster does not exist: single-node, check AgentClusterInstall conditions: name test-agent-cluster-install in namespace assisted-installer'
Can one of the admins verify this patch? |
@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1969391 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: This pull request references Bugzilla bug 1969391, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle [ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1972690, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 4 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@filanov please approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, flaper87, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1972690 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2109
/assign nmagnezi