Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting #2119

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2109

/assign nmagnezi

openshift#2027 added a more precise indication that there is no backend cluster
and directs the user to inspect AgentClusterInstall conditions.

This PR fixes a formatting issue with that msg, which looked as follows:

message: 'Failed to create image: cluster does not exist: single-node, check AgentClusterInstall
      conditions: &{Group:extensions.hive.openshift.io Version:v1beta1 Kind:AgentClusterInstall
      Name:test-agent-cluster-install}'

With this change:
message: 'Failed to create image: cluster does not exist: single-node, check AgentClusterInstall
      conditions: name test-agent-cluster-install in namespace assisted-installer'
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1969391 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh:
/bugzilla refresh

In response to this:

[ocm-2.3] Bug 1969391: Fix InfraEnv missing ACI msg formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

@openshift-ci[bot]: This pull request references Bugzilla bug 1969391, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 1969391 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Bugzilla bug 1969391 for this PR as the target_release is not set for this branch in the bugzilla plugin config. Running refresh:
/bugzilla refresh

In response to this:

[ocm-2.3] Bug 1969391: Fix InfraEnv missing ACI msg formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 29, 2021
@openshift-ci openshift-ci bot requested review from carbonin and flaper87 June 29, 2021 05:50
@nmagnezi
Copy link
Contributor

/retitle [ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting

@openshift-ci openshift-ci bot changed the title [ocm-2.3] Bug 1969391: Fix InfraEnv missing ACI msg formatting [ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting Jun 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1972690, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

4 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1969391 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • bug has dependents

Requesting review from QA contact:
/cc @bjacot

In response to this:

[ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 29, 2021
@openshift-ci openshift-ci bot requested a review from bjacot June 29, 2021 05:52
@rollandf
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@rollandf
Copy link

@filanov please approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, flaper87, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e93c428 into openshift:ocm-2.3 Jun 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1972690 has been moved to the MODIFIED state.

In response to this:

[ocm-2.3] Bug 1972690: Fix InfraEnv missing ACI msg formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants