Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-7136: Add metric report to all installation complete scenarios #2183

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

slaviered
Copy link
Contributor

Assisted Pull Request

Description

Currently only complete after finalizing is measured by metrics.
This code add metric events to all branches of installation, including
ones that are prematurely ended with error

List all the issues related to this PR

  • New Feature
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @gamli75
/cc @YuviGold

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot requested review from gamli75 and YuviGold July 7, 2021 15:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@slaviered
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 7, 2021
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021
@slaviered
Copy link
Contributor Author

/unhold
/assign @oshercc

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@slaviered
Copy link
Contributor Author

/retest

internal/cluster/transition.go Outdated Show resolved Hide resolved
internal/cluster/transition.go Outdated Show resolved Hide resolved
@slaviered
Copy link
Contributor Author

slaviered commented Jul 11, 2021

/retitle MGMT-7136: Add metric report to all installation complete scenarios

@openshift-ci openshift-ci bot changed the title MGMT-7136 - Add metric report to all installation complete scenarios MGMT-7136: Add metric report to all installation complete scenarios Jul 11, 2021
Currently only complete after finalizing is measured by metrics.
This code add metric events to all branches of installation, including
ones that are prematurely ended with error
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, slaviered

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1f1460d into openshift:master Jul 11, 2021
@gamli75
Copy link
Contributor

gamli75 commented Jul 12, 2021

/cherry-pick release_v1.0.22

@openshift-cherrypick-robot

@gamli75: new pull request created: #2195

In response to this:

/cherry-pick release_v1.0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

slaviered added a commit to slaviered/assisted-service that referenced this pull request Jul 12, 2021
…penshift#2183)

Currently only complete after finalizing is measured by metrics.
This code add metric events to all branches of installation, including
ones that are prematurely ended with error
slaviered added a commit to slaviered/assisted-service that referenced this pull request Jul 14, 2021
…penshift#2183)

Currently only complete after finalizing is measured by metrics.
This code add metric events to all branches of installation, including
ones that are prematurely ended with error
openshift-merge-robot pushed a commit that referenced this pull request Jul 14, 2021
…#2200)

* MGMT-7136:  Add metric report to all installation complete scenarios (#2183)

Currently only complete after finalizing is measured by metrics.
This code add metric events to all branches of installation, including
ones that are prematurely ended with error

* MGMT-7212: Fix crash in PostRefreshCluster (#2206)
@slaviered slaviered deleted the duration-metrics branch January 23, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants