Bug 2009204: Add error msg to InfraEnv condition #2675
Conversation
openshift-ci
bot
added
bugzilla/severity-medium
|
@rollandf: This pull request references Bugzilla bug 2009204, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rollandf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
|
@rollandf: This pull request references Bugzilla bug 2009204, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yobshans@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
/lgtm |
In case of an internal error in the InfraEnv controller reconcile loop, the condition message is showing: 'Failed to create image: internal error' With this patch, the internal error message is also available. For example: 'Failed to create image due to an internal error: failed to get secret assisted-installer/pull-secret-nope from API: secrets "pull-secret-nope" not found'
rollandf
force-pushed
the
Bug2009204-infraenv-condition-error-message
branch
from
caa5393
to
ca3089b
Compare
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@rollandf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-ocm-2.4 |
|
@rollandf: once the present PR merges, I will cherry-pick it on top of release-ocm-2.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@rollandf: All pull requests linked via external trackers have merged: Bugzilla bug 2009204 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rollandf: new pull request created: #2683 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Assisted Pull Request
Description
In case of an internal error in the InfraEnv controller reconcile loop,
the condition message is showing:
'Failed to create image: internal error'
With this patch, the internal error message is also available.
For example:
'Failed to create image due to an internal error: failed to get secret
assisted-installer/pull-secret-nope from API: secrets "pull-secret-nope" not found'
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @nmagnezi
/cc @filanov
/cc @danielerez
Checklist
docs, README, etc)Reviewers Checklist