New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2003915: pre-network-manager-config failed due to timeout when static config is used #2763
Bug 2003915: pre-network-manager-config failed due to timeout when static config is used #2763
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
23c387c
to
822f38d
Compare
why 30? and not 60? asking whether there is a specific reason for that number |
+1 on Rom's comment. This is timeout, not a fixed sleep time that we will be waiting anytime. Setting an arbitrarily big value should unblock some customers but at the same time will not slow down customers with proper (i.e. fast) network |
That was the value that worked for them. Can put even greater value. |
822f38d
to
61b864a
Compare
… static config is used - There were occasions that the pre-network-manager-config.service was timed out. Therefore, setting the static ips failed. - Increasing timeout for pre-network-manager-config.service to 60 seconds. It was checked by the customer that timeout of 30 fixes the problem.
61b864a
to
c8fd5dd
Compare
/lgtm |
/cherry-pick release-ocm-2.4 |
@ori-amizur: new pull request created: #2772 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-ocm-2.5 |
@ori-amizur: new pull request could not be created: failed to create pull request against openshift/assisted-service#release-ocm-2.5 from head openshift-cherrypick-robot:cherry-pick-2763-to-release-ocm-2.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-ocm-2.5 and openshift-cherrypick-robot:cherry-pick-2763-to-release-ocm-2.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ori-amizur: Bugzilla bug 2003915 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-ocm-2.4 |
@celebdor: new pull request created: #2773 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… static config is used (openshift#2763) - There were occasions that the pre-network-manager-config.service was timed out. Therefore, setting the static ips failed. - Increasing timeout for pre-network-manager-config.service to 60 seconds. It was checked by the customer that timeout of 30 fixes the problem.
Assisted Pull Request
Description
seconds. It was checked by the customer that timeout of 30 fixes the problem.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @yevgeny-shnaidman
Checklist
docs
, README, etc)Reviewers Checklist