Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2003915: pre-network-manager-config failed due to timeout when static config is used #2763

Merged

Conversation

ori-amizur
Copy link
Contributor

@ori-amizur ori-amizur commented Oct 13, 2021

Assisted Pull Request

Description

  • Increasing timeout for pre-network-manager-config.service to 60
    seconds. It was checked by the customer that timeout of 30 fixes the problem.

List all the issues related to this PR

  • New Feature
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @yevgeny-shnaidman

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
@romfreiman
Copy link
Contributor

why 30? and not 60? asking whether there is a specific reason for that number

@mkowalski
Copy link
Contributor

+1 on Rom's comment. This is timeout, not a fixed sleep time that we will be waiting anytime. Setting an arbitrarily big value should unblock some customers but at the same time will not slow down customers with proper (i.e. fast) network

@ori-amizur
Copy link
Contributor Author

why 30? and not 60? asking whether there is a specific reason for that number

That was the value that worked for them. Can put even greater value.

… static config is used

- There were occasions that the pre-network-manager-config.service was
  timed out.  Therefore, setting the static ips failed.
- Increasing timeout for pre-network-manager-config.service to 60
  seconds.  It was checked by the customer that timeout of 30 fixes the problem.
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit be61459 into openshift:master Oct 13, 2021
@ori-amizur
Copy link
Contributor Author

/cherry-pick release-ocm-2.4

@openshift-cherrypick-robot

@ori-amizur: new pull request created: #2772

In response to this:

/cherry-pick release-ocm-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ori-amizur
Copy link
Contributor Author

/cherry-pick release-ocm-2.5

@openshift-cherrypick-robot

@ori-amizur: new pull request could not be created: failed to create pull request against openshift/assisted-service#release-ocm-2.5 from head openshift-cherrypick-robot:cherry-pick-2763-to-release-ocm-2.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-ocm-2.5 and openshift-cherrypick-robot:cherry-pick-2763-to-release-ocm-2.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-ocm-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor celebdor changed the title OCPBUGSM-35106: pre-network-manager-config failed due to timeout when static config is used Bug 2003915: pre-network-manager-config failed due to timeout when static config is used Oct 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2021

@ori-amizur: Bugzilla bug 2003915 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 2003915: pre-network-manager-config failed due to timeout when static config is used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@celebdor
Copy link
Contributor

/cherry-pick release-ocm-2.4

@openshift-cherrypick-robot

@celebdor: new pull request created: #2773

In response to this:

/cherry-pick release-ocm-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flaper87 pushed a commit to flaper87/assisted-service that referenced this pull request Sep 21, 2022
… static config is used (openshift#2763)

- There were occasions that the pre-network-manager-config.service was
  timed out.  Therefore, setting the static ips failed.
- Increasing timeout for pre-network-manager-config.service to 60
  seconds.  It was checked by the customer that timeout of 30 fixes the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants