Bug 2065661: pin-latest.py should allow a custom tag to be set
#3507
Conversation
When publishing the Infrastructure Operator bundle and catalog to quay for the master branch, we scan the operator's manifests (clusterserviceversion in particular) for the "latest" tag and pin it to a particular image manifest digest. This is done using the pin-latest.py script and the choice of "latest" tag is hardcoded in that script. We would like to use the same script for doing similar pinning but for our release branches. In those release branches, the CSV manifest doesn't have :latest tags, it has, for example, ocm-2.5 tags. The script should be modified to accept, through an environment variable, a different tag that needs to be pinned, so it can be used in release branch catalog/bundle quay publishing CI jobs.
openshift-ci
bot
added
the
bugzilla/severity-low
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
@omertuc: This pull request references Bugzilla bug 2065661, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
=======================================
Coverage 67.12% 67.13%
=======================================
Files 171 171
Lines 24190 24190
=======================================
+ Hits 16237 16239 +2
+ Misses 6393 6392 -1
+ Partials 1560 1559 -1
|
|
/lgtm |
|
Waiting for openshift/release#27102 to merge to get rid of invalid |
|
/bugzilla refresh |
|
@omertuc: This pull request references Bugzilla bug 2065661, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@omertuc: This pull request references Bugzilla bug 2065661, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@omertuc: This pull request references Bugzilla bug 2065661, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@omertuc: All pull requests linked via external trackers have merged: Bugzilla bug 2065661 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@omertuc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick ocm-2.5 |
|
/cherry-pick release-ocm-2.5 |
|
@omertuc: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@omertuc: new pull request created: #3509 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…nshift#3507) When publishing the Infrastructure Operator bundle and catalog to quay for the master branch, we scan the operator's manifests (clusterserviceversion in particular) for the "latest" tag and pin it to a particular image manifest digest. This is done using the pin-latest.py script and the choice of "latest" tag is hardcoded in that script. We would like to use the same script for doing similar pinning but for our release branches. In those release branches, the CSV manifest doesn't have :latest tags, it has, for example, ocm-2.5 tags. The script should be modified to accept, through an environment variable, a different tag that needs to be pinned, so it can be used in release branch catalog/bundle quay publishing CI jobs.
…nshift#3507) When publishing the Infrastructure Operator bundle and catalog to quay for the master branch, we scan the operator's manifests (clusterserviceversion in particular) for the "latest" tag and pin it to a particular image manifest digest. This is done using the pin-latest.py script and the choice of "latest" tag is hardcoded in that script. We would like to use the same script for doing similar pinning but for our release branches. In those release branches, the CSV manifest doesn't have :latest tags, it has, for example, ocm-2.5 tags. The script should be modified to accept, through an environment variable, a different tag that needs to be pinned, so it can be used in release branch catalog/bundle quay publishing CI jobs.
When publishing the Infrastructure Operator bundle and catalog to quay
for the master branch, we scan the operator's manifests
(clusterserviceversion in particular) for the "latest" tag and pin it to
a particular image manifest digest. This is done using the pin-latest.py
script and the choice of "latest" tag is hardcoded in that script.
We would like to use the same script for doing similar pinning but for
our release branches. In those release branches, the CSV manifest
doesn't have :latest tags, it has, for example, ocm-2.5 tags.
The script should be modified to accept, through an environment
variable, a different tag that needs to be pinned, so it can be used in
release branch catalog/bundle quay publishing CI jobs.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @adriengentil
Checklist
docs, README, etc)Reviewers Checklist