Bug 2097696: Call cluster-info with a namespace

[nmagnezi]

In some cases, the user does not own the cluster and thus cannot
run cluster-info without the scope of a namespace.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

/cc @osherdp
/cc @omertuc

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[nmagnezi]

how it looked when I ran it locally (on a minikube node):

Successfully built cc32c0f82786
Successfully tagged assisted-service-build:latest
python3 ./tools/wait_for_cluster_info.py --namespace "assisted-installer"
2022-03-29 08:17:40.156445 DEBUG - kubectl --namespace assisted-installer cluster-info
Kubernetes control plane is running at https://192.168.76.2:8443

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmagnezi, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nmagnezi,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #3585 (12f093c) into master (dc59fc0) will increase coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3585      +/-   ##
==========================================
+ Coverage   66.57%   67.48%   +0.90%     
==========================================
  Files         172      176       +4     
  Lines       24488    26710    +2222     
==========================================
+ Hits        16303    18025    +1722     
- Misses       6593     6950     +357     
- Partials     1592     1735     +143     

Impacted Files	Coverage Δ
internal/cluster/common.go	73.71% <0.00%> (-4.96%)	⬇️
internal/host/hostutil/host_utils.go	34.40% <0.00%> (-3.66%)	⬇️
internal/network/utils.go	23.56% <0.00%> (-2.13%)	⬇️
internal/common/test_configuration.go	0.00% <0.00%> (ø)
pkg/validations/validations.go	91.66% <0.00%> (ø)
...al/controller/controllers/agentlabel_controller.go	57.14% <0.00%> (ø)
...ller/controllers/agentclassification_controller.go	57.89% <0.00%> (ø)
...all/v1beta1/agent_classification_admission_hook.go	79.33% <0.00%> (ø)
internal/cluster/validator.go	84.91% <0.00%> (+0.69%)	⬆️
internal/network/machine_network_cidr.go	61.87% <0.00%> (+0.88%)	⬆️
... and 7 more

[omertuc]

🤦‍♂️ The --help doesn't mention anything about a namespace... oh well

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[nmagnezi]

/retest-required

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[osherdp]

/override ci/prow/e2e-metal-assisted-kube-api-net-suite
(broken)

[openshift-ci]

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/e2e-metal-assisted-kube-api-net-suite

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-net-suite
(broken)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@nmagnezi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@nmagnezi: All pull requests linked via external trackers have merged:

• openshift/assisted-service#3572
• openshift/assisted-service#3585

Bugzilla bug 2097696 has been moved to the MODIFIED state.

In response to this:

Bug 2097696: Call cluster-info with a namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.