New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2069976: oc client in AI failed to resolve MCO image when working with oc-mirror #3754
Bug 2069976: oc client in AI failed to resolve MCO image when working with oc-mirror #3754
Conversation
…c client in AI (openshift#3598) Updated the oc-image to an updated version of oc that support the new oc-mirror behavior This oc image was built from this commit: eranco74/oc@20d61f4
@eranco74: This pull request references Bugzilla bug 2069976, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@eranco74: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #3754 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 176 176
Lines 24595 24595
=======================================
Hits 16148 16148
Misses 6884 6884
Partials 1563 1563 |
/retest |
/lgtm |
/test edge-e2e-metal-assisted-operator-disconnected |
metal-assisted-operator-disconnected pass |
@eranco74: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@eranco74: All pull requests linked via external trackers have merged: Bugzilla bug 2069976 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No need for cherry-picking, this should update 2.5 downstream image |
…c client in AI (openshift#3598) (openshift#3754) Updated the oc-image to an updated version of oc that support the new oc-mirror behavior This oc image was built from this commit: eranco74/oc@20d61f4
…c client in AI (openshift#3598) (openshift#3754) Updated the oc-image to an updated version of oc that support the new oc-mirror behavior This oc image was built from this commit: eranco74/oc@20d61f4
Updated the oc-image to an updated version of oc that support the new oc-mirror behavior
The oc image was built from this commit:
eranco74/oc@20d61f4
-->
List all the issues related to this PR
https://bugzilla.redhat.com/show_bug.cgi?id=2069976
What environments does this code impact?
Disconnected environment
How was this code tested?
Tested the functionality of the oc client in a disconnected env against mirror registry while creating the release mirror with
oc adm release mirror
andoc-mirror
, in both cases the oc client manage to return the right image for MCO and extract the installer binaryAssignees
/cc @tsorya
/cc @yevgeny-shnaidman
Checklist
docs
, README, etc)Reviewers Checklist