Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2069976: oc client in AI failed to resolve MCO image when working with oc-mirror #3754

Conversation

eranco74
Copy link
Contributor

@eranco74 eranco74 commented May 3, 2022

Updated the oc-image to an updated version of oc that support the new oc-mirror behavior
The oc image was built from this commit:
eranco74/oc@20d61f4

  • Should this PR be tested by the reviewer? not a must
  • Is this PR relying on CI for an e2e test run? for regression
  • Should this PR be tested in a specific environment? disconnected env using a mirror registry created with oc-mirror
  • Any logs, screenshots, etc that can help with the review process? no

-->

List all the issues related to this PR

https://bugzilla.redhat.com/show_bug.cgi?id=2069976

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

Disconnected environment

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Tested the functionality of the oc client in a disconnected env against mirror registry while creating the release mirror with oc adm release mirror and oc-mirror, in both cases the oc client manage to return the right image for MCO and extract the installer binary

Assignees

/cc @tsorya
/cc @yevgeny-shnaidman

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

…c client in AI (openshift#3598)

Updated the oc-image to an updated version of oc that support the new oc-mirror behavior
This oc image was built from this commit:
eranco74/oc@20d61f4
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

@eranco74: This pull request references Bugzilla bug 2069976, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (rhacm-2.6) matches configured target release for branch (rhacm-2.6)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2069976: oc client in AI failed to resolve MCO image when working with oc-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels May 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@eranco74
Copy link
Contributor Author

eranco74 commented May 3, 2022

/hold
/test e2e-metal-assisted-operator-disconnected
/test e2e-metal-assisted-operator-ztp

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

@eranco74: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test edge-ci-index
  • /test edge-e2e-metal-assisted
  • /test edge-e2e-metal-assisted-cnv
  • /test edge-e2e-metal-assisted-ipv6
  • /test edge-e2e-metal-assisted-ocs
  • /test edge-e2e-metal-assisted-operator-ztp
  • /test edge-images
  • /test edge-lint
  • /test edge-subsystem-aws
  • /test edge-subsystem-kubeapi-aws
  • /test edge-unit-test
  • /test edge-verify-generated-code
  • /test images

The following commands are available to trigger optional jobs:

  • /test edge-e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49
  • /test edge-e2e-ai-operator-ztp-ipv4v6-sno-ocp-49
  • /test edge-e2e-metal-assisted-4-10
  • /test edge-e2e-metal-assisted-4-6
  • /test edge-e2e-metal-assisted-4-8
  • /test edge-e2e-metal-assisted-4-9
  • /test edge-e2e-metal-assisted-capi
  • /test edge-e2e-metal-assisted-day2
  • /test edge-e2e-metal-assisted-ipv4v6
  • /test edge-e2e-metal-assisted-kube-api-late-binding-single-node
  • /test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
  • /test edge-e2e-metal-assisted-kube-api-net-suite
  • /test edge-e2e-metal-assisted-none
  • /test edge-e2e-metal-assisted-onprem
  • /test edge-e2e-metal-assisted-operator-capi
  • /test edge-e2e-metal-assisted-operator-disconnected
  • /test edge-e2e-metal-assisted-operator-ztp-multinode-spoke
  • /test edge-e2e-metal-assisted-single-node
  • /test edge-e2e-metal-assisted-static-ip-suite
  • /test edge-e2e-metal-assisted-tpmv2

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-images

In response to this:

/hold
/test e2e-metal-assisted-operator-disconnected
/test e2e-metal-assisted-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #3754 (6ec4e1e) into master (763d20c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3754   +/-   ##
=======================================
  Coverage   65.65%   65.65%           
=======================================
  Files         176      176           
  Lines       24595    24595           
=======================================
  Hits        16148    16148           
  Misses       6884     6884           
  Partials     1563     1563           

@tsorya
Copy link
Contributor

tsorya commented May 3, 2022

/retest

@tsorya
Copy link
Contributor

tsorya commented May 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@eranco74
Copy link
Contributor Author

eranco74 commented May 3, 2022

/test edge-e2e-metal-assisted-operator-disconnected

@eranco74
Copy link
Contributor Author

eranco74 commented May 4, 2022

metal-assisted-operator-disconnected pass
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

@eranco74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c74a8e3 into openshift:master May 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

@eranco74: All pull requests linked via external trackers have merged:

Bugzilla bug 2069976 has been moved to the MODIFIED state.

In response to this:

Bug 2069976: oc client in AI failed to resolve MCO image when working with oc-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eranco74
Copy link
Contributor Author

eranco74 commented May 4, 2022

No need for cherry-picking, this should update 2.5 downstream image

flaper87 pushed a commit to flaper87/assisted-service that referenced this pull request Sep 21, 2022
…c client in AI (openshift#3598) (openshift#3754)

Updated the oc-image to an updated version of oc that support the new oc-mirror behavior
This oc image was built from this commit:
eranco74/oc@20d61f4
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
…c client in AI (openshift#3598) (openshift#3754)

Updated the oc-image to an updated version of oc that support the new oc-mirror behavior
This oc image was built from this commit:
eranco74/oc@20d61f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants