MGMT-9682: fix default disk size requirement

[osherdp]

Seems like since OCP 4.6, disk requirements were set on 100GB for all nodes:
https://docs.openshift.com/container-platform/4.6/installing/installing_bare_metal/installing-bare-metal.html#minimum-resource-requirements_installing-bare-metal

Since we don't support installation of OCP <= 4.5 in any environment, it makes sense to change it for all OCP minor releases.

This PR is not doing relevant changes for the operator (in the agentserviceconfig object), as it should follow BZ tickets instead of Jira ones.

I've tested local environments of minikube and podman, trying to create envs with different disk sizes. I'll also follow up checking integration env preflight-requirements endpoint.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

@gamli75 @eliorerz

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[codecov]

Codecov Report

Merging #3802 (8763016) into master (ca34804) will increase coverage by 3.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
+ Coverage   66.29%   69.31%   +3.02%     
==========================================
  Files         174      174              
  Lines       24209    26778    +2569     
==========================================
+ Hits        16049    18561    +2512     
+ Misses       6671     6644      -27     
- Partials     1489     1573      +84     

Impacted Files	Coverage Δ
internal/host/validator.go	76.34% <0.00%> (-0.20%)	⬇️
internal/host/hostcommands/install_cmd.go	80.69% <0.00%> (-0.19%)	⬇️
internal/host/common.go	76.78% <0.00%> (ø)
internal/host/statemachine.go	100.00% <0.00%> (ø)
internal/host/validation_id.go	90.90% <0.00%> (ø)
internal/host/pool_host_statemachine.go	100.00% <0.00%> (ø)
internal/host/refresh_status_preprocessor.go	95.34% <0.00%> (+0.11%)	⬆️
internal/cluster/cluster.go	68.53% <0.00%> (+0.24%)	⬆️
internal/cluster/validations/validations.go	44.56% <0.00%> (+0.74%)	⬆️
internal/host/transition.go	50.70% <0.00%> (+1.31%)	⬆️
... and 7 more

[osherdp]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gamli75,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[osherdp]

/unhold

[openshift-ci]

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.