AGENT-171: Update machine-api-operator and related dependencies

[lranjbar]

Working on updating the agent-installer branch in openshift/installer. I'm getting some dependency error centered around the old version of MAO that assisted-service uses.

Error:

go: github.com/openshift/assisted-service@v1.0.10-0.20220223093655-7ada9949bf1d requires
	github.com/openshift/machine-api-operator@v0.2.1-0.20201002104344-6abfb5440597 requires
	sigs.k8s.io/cluster-api-provider-aws@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

Commands run:

• go get -u github.com/openshift/machine-api-operator
• go get -u github.com/metal3-io/baremetal-operator
• go mod -t ./...
• go mod tidy
• go mod vendor

Built locally using skipper make validate.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

/cc @pawanpinjarkar
/cc @andfasano

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lranjbar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lranjbar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #3871 (c0783e2) into master (b5c877d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3871      +/-   ##
==========================================
- Coverage   66.22%   66.20%   -0.02%     
==========================================
  Files         179      179              
  Lines       24872    24887      +15     
==========================================
+ Hits        16472    16477       +5     
- Misses       6877     6883       +6     
- Partials     1523     1527       +4     

Impacted Files	Coverage Δ
internal/controller/controllers/common.go	77.00% <0.00%> (-1.07%)	⬇️
internal/oc/release.go	72.29% <0.00%> (-1.00%)	⬇️
...ler/controllers/preprovisioningimage_controller.go	65.21% <0.00%> (-0.87%)	⬇️

[zaneb]

It's complaining because that version of MAO used a replace directive for CAPAWS, with the version not listed in the require section. This means that all (indirect) consumers must also replace with the version they want. The installer was doing this anyway, but recently stopped, so that's why it broke on merge.

openshift/installer#5970 works around this, but it certainly wouldn't hurt to update to more recent dependencies. (I assume it's safe to remove the replace directive for the AWS and maybe Azure CAPI providers now too.)

[openshift-ci]

@lranjbar: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[romfreiman]

What are our plans to solve this vendoring requirement?

[celebdor]

We'll work to move out of vendoring by using cachito in the CI/release pipelines

[openshift-ci]

@lranjbar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-ai-operator-ztp-converged	c0783e2	link	true	/test edge-e2e-ai-operator-ztp-converged
ci/prow/mce-images	c0783e2	link	true	/test mce-images
ci/prow/edge-e2e-ai-operator-ztp	c0783e2	link	true	/test edge-e2e-ai-operator-ztp
ci/prow/edge-verify-generated-code	c0783e2	link	true	/test edge-verify-generated-code
ci/prow/edge-unit-test	c0783e2	link	true	/test edge-unit-test
ci/prow/edge-lint	c0783e2	link	true	/test edge-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.